{containerapp} remove additional conversion of binding name of Java component#7335
Merged
zhoxing-ms merged 19 commits intoMar 1, 2024
Conversation
Sync with the official repo
Sync with the official repo
Sync with the official repo
Synced with official repo
Sync with the official repo
Sync with the official repo
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @ShichaoQiu, |
|
Hi @ShichaoQiu, |
microsoft-github-policy-service
Bot
requested review from
wangzelin007,
yanzhudd and
yonzhan
Collaborator
|
Containerapp |
microsoft-github-policy-service
Bot
requested review from
JennyLawrance,
ebencarek,
jsntcy,
ruslany,
sanchitmehta and
zhoxing-ms
microsoft-github-policy-service
Bot
requested review from
Greedygre,
Juliehzl,
chinadragon0515,
howang-ms,
jijohn14,
pagariyaalok,
torosent,
vinisoto and
vturecek
Contributor
|
Please rerun tests relate to it, for example: test_containerapp_java_component |
Greedygre
approved these changes
Mar 1, 2024
Contributor
|
This PR is for fix a logic which has not been released for customer in PR #7216, so no need to update |
ShichaoQiu
changed the title
Juliehzl
reviewed
Mar 1, 2024
Juliehzl
reviewed
Mar 1, 2024
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
add test case for '-' scenario
4 tasks
Greedygre
approved these changes
Mar 1, 2024
zhoxing-ms
approved these changes
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove additional conversion of binding name of Java component