Skip to content

{AKS} BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity#7590

Merged
yanzhudd merged 3 commits intoAzure:mainfrom
FumingZhang:fuming/aks-fix-test-0508
May 10, 2024
Merged

{AKS} BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity#7590
yanzhudd merged 3 commits intoAzure:mainfrom
FumingZhang:fuming/aks-fix-test-0508

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented May 8, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

  • {AKS} BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity, sync change from azure-cli #28906.
  • {AKS} Fix several recording files broken by dependency bump (compute #28847)
    • test_aks_check_network
    • test_aks_create_and_update_with_http_proxy_config

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@FumingZhang FumingZhang requested a review from andyliuliming as a code owner May 8, 2024 02:42
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 8, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove aks create cmd aks create update parameter enable_managed_identity: removed property default=True

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 8, 2024

AKS

@FumingZhang FumingZhang changed the title {AKS} Fix several recording files broken by dependency bump {AKS} BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity May 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

⚠️ Release Suggestions

Module: aks-preview

  • ⚠️ Please update VERSION to be 3.0.0b14 in src/aks-preview/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@yanzhudd yanzhudd merged commit 7b5d54b into Azure:main May 10, 2024
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=156941&view=results

@FumingZhang FumingZhang deleted the fuming/aks-fix-test-0508 branch May 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants