Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions linter_exclusions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ aks create:
aad_admin_group_object_ids:
rule_exclusions:
- option_length_too_long
aad_server_app_secret:
rule_exclusions:
- option_length_too_long
api_server_authorized_ip_ranges:
rule_exclusions:
- option_length_too_long
Expand Down
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ If there is no rush to release a new version, please just add a description of t

To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z -> Major.Minor.Patch, more details in `\doc <https://semver.org/>`_), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number.

11.0.0b1
+++++++
* [BREAKING CHANGE]: `az aks create`: Remove AAD-legacy properties `--aad-client-app-id`, `--aad-server-app-id` and `--aad-server-app-secret` when creating cluster.

10.0.0b1
++++++++
* [BREAKING CHANGE]: `az aks create/update`: Remove `--uptime-sla` and `--no-uptime-sla` options.
Expand Down
16 changes: 1 addition & 15 deletions src/aks-preview/azext_aks_preview/_help.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,20 +106,6 @@
- name: --aad-admin-group-object-ids
type: string
short-summary: Comma-separated list of aad group object IDs that will be set as cluster admin.
- name: --aad-client-app-id
type: string
short-summary: The ID of an Azure Active Directory client application of type "Native". This
application is for user login via kubectl.
long-summary: --aad-client-app-id is deprecated. See https://aka.ms/aks/aad-legacy for details.
- name: --aad-server-app-id
type: string
short-summary: The ID of an Azure Active Directory server application of type "Web app/API". This
application represents the managed cluster's apiserver (Server application).
long-summary: --aad-server-app-id is deprecated. See https://aka.ms/aks/aad-legacy for details.
- name: --aad-server-app-secret
type: string
short-summary: The secret of an Azure Active Directory server application.
long-summary: --aad-server-app-secret is deprecated. See https://aka.ms/aks/aad-legacy for details.
- name: --aad-tenant-id
type: string
short-summary: The ID of an Azure Active Directory tenant.
Expand Down Expand Up @@ -1309,7 +1295,7 @@
text: az aks update -g MyResourceGroup -n MyManagedCluster --api-server-authorized-ip-ranges 0.0.0.0/32
- name: Update a AKS-managed AAD cluster with tenant ID or admin group object IDs.
text: az aks update -g MyResourceGroup -n MyManagedCluster --aad-admin-group-object-ids <id-1,id-2> --aad-tenant-id <id>
- name: Migrate a AKS AAD-Integrated cluster or a non-AAAAD cluster to a AKS-managed AAD cluster.
- name: Migrate a AKS AAD-Integrated cluster or a non-AAD cluster to a AKS-managed AAD cluster.
text: az aks update -g MyResourceGroup -n MyManagedCluster --enable-aad --aad-admin-group-object-ids <id-1,id-2> --aad-tenant-id <id>
- name: Enable Azure Hybrid User Benefits featture for a kubernetes cluster.
text: az aks update -g MyResourceGroup -n MyManagedCluster --enable-ahub
Expand Down
12 changes: 0 additions & 12 deletions src/aks-preview/azext_aks_preview/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,18 +582,6 @@ def load_arguments(self, _):
)
c.argument("enable_aad", action="store_true")
c.argument("enable_azure_rbac", action="store_true")
c.argument(
"aad_client_app_id",
deprecate_info=c.deprecate(target="--aad-client-app-id", hide=True),
)
c.argument(
"aad_server_app_id",
deprecate_info=c.deprecate(target="--aad-server-app-id", hide=True),
)
c.argument(
"aad_server_app_secret",
deprecate_info=c.deprecate(target="--aad-server-app-secret", hide=True),
)
c.argument("aad_tenant_id")
c.argument("aad_admin_group_object_ids")
c.argument("enable_oidc_issuer", action="store_true")
Expand Down
3 changes: 0 additions & 3 deletions src/aks-preview/azext_aks_preview/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,6 @@ def aks_create(
assign_kubelet_identity=None,
enable_aad=False,
enable_azure_rbac=False,
aad_client_app_id=None,
aad_server_app_id=None,
aad_server_app_secret=None,
aad_tenant_id=None,
aad_admin_group_object_ids=None,
enable_oidc_issuer=False,
Expand Down
Loading