Skip to content

{Image-copy} Remove direct call to msrestazure #8232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsntcy merged 2 commits into from
Nov 7, 2024
Merged

{Image-copy} Remove direct call to msrestazure #8232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
276379a
remove msrest
Jing-song Nov 4, 2024
bc4fe1e
update
Jing-song Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/image-copy/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Release History
===============

1.0.0
++++++
* Remove direct call to `msrestazure`

0.2.13
++++++
* [BREAKING CHANGE] Deprecated non-compliant parameter name '--temporary_resource_group_name'.
Expand Down
2 changes: 1 addition & 1 deletion src/image-copy/azext_imagecopy/azext_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"azext.minCliCoreVersion": "2.0.24"
"azext.minCliCoreVersion": "2.66.0"
}
2 changes: 1 addition & 1 deletion src/image-copy/azext_imagecopy/cli_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def prepare_cli_command(cmd, output_as_json=True, tags=None, subscription=None,


def get_storage_account_id_from_blob_path(blob_path, resource_group, subscription_id):
from msrestazure.tools import resource_id
from azure.mgmt.core.tools import resource_id

logger.debug('Getting storage account id for blob: %s', blob_path)

Expand Down
2 changes: 1 addition & 1 deletion src/image-copy/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "0.2.13"
VERSION = "1.0.0"

CLASSIFIERS = [
'Development Status :: 4 - Beta',
Expand Down