AKS: Fix storage pool name validation for Azure Container Storage#8233
Merged
Conversation
mukhoakash
requested review from
FumingZhang and
andyliuliming
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @mukhoakash, |
azure-client-tools-bot-prd
Bot
added this to the
November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
|
Hi @mukhoakash, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
Contributor
|
Hi @mukhoakash
|
FumingZhang
reviewed
Nov 5, 2024
Member
There was a problem hiding this comment.
lgtm
Queued live test to validate the change, test passed!
- test_aks_create_with_azurecontainerstorage
- test_aks_update_with_azurecontainerstorage
- test_aks_create_with_azurecontainerstorage_with_ephemeral_disk_parameters
- test_aks_update_with_azurecontainerstorage_with_ephemeral_disk_parameters
- test_aks_create_with_azurecontainerstorage_with_nodepool_name
Contributor
|
It is a known issue and has been fixed. Please rebase from the main branch to pick up the fix. |
…into mukhoakash/fix-acstor-update
FumingZhang
approved these changes
Nov 7, 2024
github-actions
Bot
added
the
release-version-block
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
yanzhudd
added
minor
github-actions
Bot
removed
the
release-version-block
yanzhudd
approved these changes
Nov 7, 2024
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=204174&view=results |
chrisribe
pushed a commit
to chrisribe/azure-cli-extensions
that referenced
this pull request
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…name
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.