[Azure Load Testing] Adding disable-public-ip argument in load extension#8239
Merged
kairu-ms merged 7 commits intoNov 7, 2024
Merged
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| load test create | cmd load test create added parameter disable_public_ip |
||
| load test update | cmd load test update added parameter disable_public_ip |
azure-client-tools-bot-prd
Bot
added this to the
November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
|
Hi @Himanshu49, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
requested review from
jsntcy,
kairu-ms and
necusjz
Contributor
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Contributor
|
github-actions
Bot
added
the
release-version-block
github-actions
Bot
removed
the
release-version-block
prativen
approved these changes
Nov 6, 2024
sulabh-msft
reviewed
Nov 6, 2024
sulabh-msft
approved these changes
Nov 6, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
Please fix CI issues |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8239 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8239 in repo Azure/azure-cli-extensions |
Member
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8239 in repo Azure/azure-cli-extensions |
mitsha-microsoft
approved these changes
Nov 6, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
approved these changes
Nov 7, 2024
Collaborator
|
[Release] Update index.json for extension [ load ] : https://dev.azure.com/azclitools/release/_build/results?buildId=204207&view=results |
chrisribe
pushed a commit
to chrisribe/azure-cli-extensions
that referenced
this pull request
Nov 13, 2024
…ion (Azure#8239) * Adding support for publicIPDisabled * Added test cases for public ip disabled param * Changing version from 1.1.2 to 1.2.0 as its minor changes and not patch * nit: condition refactoring and pushing new recordings * added more test cases * nit: fixing CI failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we have
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.