{compute-diagnostic} Remove az compute-diagnostic command group#8240
Merged
kairu-ms merged 3 commits intoNov 7, 2024
Merged
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
azure-client-tools-bot-prd
Bot
added this to the
November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
joal42
changed the title
Contributor
|
Please remove the extension in https://github.com/Azure/azure-cli-extensions/blob/main/src/index.json as well |
Contributor
Author
removed |
Contributor
|
@microsoft-github-policy-service rerun |
1 similar comment
Contributor
|
@microsoft-github-policy-service rerun |
kairu-ms
approved these changes
Nov 7, 2024
chrisribe
pushed a commit
to chrisribe/azure-cli-extensions
that referenced
this pull request
Nov 13, 2024
…e#8240) * Delete src/compute-diagnostic-rp directory * Update service_name.json * remove compute-diagnostic from index.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az compute-diagnosticremove this command group from cli extension, as its new versionaz compute-recommenderis created in cli.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.