[AKS] BREAKING CHANGE: az aks trustedaccess rolebinding create: Remove deprecated -r and -s options#8243
Merged
Merged
Conversation
YitongFeng-git
requested review from
FumingZhang and
andyliuliming
as code owners
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks trustedaccess rolebinding create | cmd aks trustedaccess rolebinding create update parameter source_resource_id: removed property options_deprecate_info=[{'target': '-s', 'redirect': '--source-resource-id', 'hide': True}, {'target': '-r', 'redirect': '--source-resource-id', 'hide': True}] |
azure-client-tools-bot-prd
Bot
added this to the
November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
|
Hi @YitongFeng-git, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
YitongFeng-git
changed the title
az aks trustedaccess rolebinding create: Remove deprecated -r optionsaz aks trustedaccess rolebinding create: Remove deprecated -r and -s options
YitongFeng-git
force-pushed
the
yife/ext
branch
from
e2b0562 to
ac93077
Compare
Contributor
|
FumingZhang
reviewed
Nov 6, 2024
YitongFeng-git
force-pushed
the
yife/ext
branch
from
ac93077 to
dce744b
Compare
github-actions
Bot
added
release-version-block
github-actions
Bot
added
the
release-version-block
YitongFeng-git
force-pushed
the
yife/ext
branch
from
89f9726 to
7938449
Compare
YitongFeng-git
force-pushed
the
yife/ext
branch
from
7938449 to
192b3d3
Compare
github-actions
Bot
removed
the
release-version-block
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=204223&view=results |
chrisribe
pushed a commit
to chrisribe/azure-cli-extensions
that referenced
this pull request
Nov 13, 2024
…ove deprecated `-r` and `-s` options (Azure#8243)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks trustedaccess rolebinding create
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.