Skip to content

{CI} Disable persist credentials#8245

Merged
wangzelin007 merged 1 commit into
Azure:mainfrom
wangzelin007:disable-persistCredentials
Nov 7, 2024
Merged

{CI} Disable persist credentials#8245
wangzelin007 merged 1 commit into
Azure:mainfrom
wangzelin007:disable-persistCredentials

Conversation

@wangzelin007
Copy link
Copy Markdown
Member

@wangzelin007 wangzelin007 commented Nov 7, 2024


persistCredentials: true leave the OAuth token in the Git config after the initial fetch. The default is not to leave it., which may lead to security risks.
https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/steps-checkout?view=azure-pipelineshttps://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/steps-checkout?view=azure-pipelines

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Nov 7, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @wangzelin007,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 7, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 7, 2024

@wangzelin007 wangzelin007 merged commit 8021435 into Azure:main Nov 7, 2024
YitongFeng-git pushed a commit to YitongFeng-git/azure-cli-extensions that referenced this pull request Nov 7, 2024
chrisribe pushed a commit to chrisribe/azure-cli-extensions that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants