add support for bastion developer create#8366
Merged
Merged
Conversation
|
Hi @zhangjacq, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network bastion create | cmd network bastion create added parameter network_acls_ips |
||
| network bastion create | cmd network bastion create update parameter public_ip_address: removed property required=True |
||
| network bastion create | cmd network bastion create update parameter sku: updated property choices from ['Basic', 'Premium', 'Standard'] to ['Basic', 'Developer', 'Premium', 'Standard'] |
||
| network bastion create | cmd network bastion create update parameter tags: added property aaz_default={} |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA |
microsoft-github-policy-service
Bot
requested review from
jsntcy,
kairu-ms,
necusjz and
yonzhan
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Contributor
|
kairu-ms
approved these changes
Jan 7, 2025
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Member
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8366 in repo Azure/azure-cli-extensions |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8366 in repo Azure/azure-cli-extensions |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
necusjz
approved these changes
Feb 6, 2025
Collaborator
|
[Release] Update index.json for extension [ bastion-1.4.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=114437701&view=results |
Jenniferyingni
pushed a commit
to Jenniferyingni/azure-cli-extensions
that referenced
this pull request
Feb 9, 2025
* add support for bastion developer create * space-separated ip addresses for network acls * add history * features vars naming * check fix * re-record tests * attempt to fix api-version for vnet PUT * update recording --------- Co-authored-by: Jacques Zhang <zhangja@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az network bastion create --name MyBastion --resource-group MyResourceGroup --sku Developer --vnet-name MyVnetaz network bastion create --name MyBastion --resource-group MyResourceGroup --sku Developer --vnet-name MyVnet --network-acls-ips '[{"addressPrefix":"1.1.1.1/16"},{"addressPrefix":"100.64.0.0/10"}]'General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.