Skip to content

fix 'az aks nodepool upgrade' cannot set 'node-soak-duration' to 0#8443

Merged
yanzhudd merged 3 commits into
Azure:mainfrom
zjpjack-github:jizen/node-soak-duration-fix
Feb 7, 2025
Merged

fix 'az aks nodepool upgrade' cannot set 'node-soak-duration' to 0#8443
yanzhudd merged 3 commits into
Azure:mainfrom
zjpjack-github:jizen/node-soak-duration-fix

Conversation

@zjpjack-github
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool upgrade

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Jan 28, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @zjpjack-github,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jan 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2025

Copy link
Copy Markdown
Member

@andyliuliming andyliuliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yanzhudd
Copy link
Copy Markdown
Contributor

yanzhudd commented Feb 5, 2025

Hi @FumingZhang could you please review this PR as well?

@yanzhudd
Copy link
Copy Markdown
Contributor

yanzhudd commented Feb 5, 2025

Please fix the CI issues.

Comment thread src/aks-preview/azext_aks_preview/custom.py Outdated
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanzhudd
Copy link
Copy Markdown
Contributor

yanzhudd commented Feb 7, 2025

Do you want to release a new version for this change? If so, please upgrade the version in setup.py as well.

@yanzhudd
Copy link
Copy Markdown
Contributor

yanzhudd commented Feb 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit a3f7316 into Azure:main Feb 7, 2025
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Feb 7, 2025

[Release] Update index.json for extension [ aks-preview-13.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=114573497&view=results

Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants