{AKS} xmzhao/update outboundtype automatic#8446
Conversation
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
…hao0822/azure-cli-extensions into xmzhao/update-outboundtype-automatic
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
It seems that you have added the unit test for your changes. It would be better if you could add a corresponding live test :)
I tested using staging region and the result showed the outbound type will use load balancer if user specify the BYO Vnet in the CLI to create automnatic cluster, which met our expection. The RP release is still rolling out the backend change to production regions. I will add corresponding live test in next PR. |
|
[Release] Update index.json for extension [ aks-preview-13.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=114435406&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.