Skip to content

{AKS} xmzhao/update outboundtype automatic#8446

Merged
zhoxing-ms merged 73 commits into
Azure:mainfrom
xmzhao0822:xmzhao/update-outboundtype-automatic
Feb 6, 2025
Merged

{AKS} xmzhao/update outboundtype automatic#8446
zhoxing-ms merged 73 commits into
Azure:mainfrom
xmzhao0822:xmzhao/update-outboundtype-automatic

Conversation

@xmzhao0822
Copy link
Copy Markdown
Contributor

@xmzhao0822 xmzhao0822 commented Jan 29, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jan 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 29, 2025

Comment thread src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Outdated
@xmzhao0822 xmzhao0822 marked this pull request as ready for review February 4, 2025 17:08
@xmzhao0822 xmzhao0822 changed the title Xmzhao/update outboundtype automatic {AKS} xmzhao/update outboundtype automatic Feb 5, 2025
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It seems that you have added the unit test for your changes. It would be better if you could add a corresponding live test :)

@xmzhao0822
Copy link
Copy Markdown
Contributor Author

xmzhao0822 commented Feb 5, 2025

LGTM

It seems that you have added the unit test for your changes. It would be better if you could add a corresponding live test :)

I tested using staging region and the result showed the outbound type will use load balancer if user specify the BYO Vnet in the CLI to create automnatic cluster, which met our expection. The RP release is still rolling out the backend change to production regions. I will add corresponding live test in next PR.

@zhoxing-ms zhoxing-ms merged commit 1c70844 into Azure:main Feb 6, 2025
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Feb 6, 2025

[Release] Update index.json for extension [ aks-preview-13.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=114435406&view=results

Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants