Skip to content

Update repair-button and repair-and-restore descriptions and --button-command help text#8488

Open
divargas-msft wants to merge 6 commits into
Azure:mainfrom
divargas-msft:patch-1
Open

Update repair-button and repair-and-restore descriptions and --button-command help text#8488
divargas-msft wants to merge 6 commits into
Azure:mainfrom
divargas-msft:patch-1

Conversation

@divargas-msft
Copy link
Copy Markdown

Modifying the repair-button --button-command text


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Modifying the repair-button --button-command text
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @divargas-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2025

Modifying the summary for both repair-button and repair-and-restore to make them more accurate
Increasing version number as instructed by Adam Sandor
updating release history
@divargas-msft divargas-msft changed the title Update _params.py Update repair-button and repair-and-restore descriptions and --button-command help text Feb 18, 2025
Comment thread src/vm-repair/azext_vm_repair/_help.py Outdated
Comment thread src/vm-repair/azext_vm_repair/_help.py Outdated

with self.argument_context('vm repair repair-button') as c:
c.argument('button_command', help='Button_command for repair VM.')
c.argument('button_command', help='Specific ALAR script being used for repair VM.')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just a flag parameter? or can it take values? If it can take in values, is this cmd only specified to run the alar2 script? If it's not alar specific, remove that mention and just describe what it does.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sandido the --button-command needs to receive the name of an ALAR function/command as a value ( and it needs that value to work)

divargas-msft and others added 2 commits February 19, 2025 15:15
Minor wording fix

Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Minor wording fix

Co-authored-by: Adam Sandor <adsandor@microsoft.com>
@divargas-msft
Copy link
Copy Markdown
Author

@Sandido your other 2 suggestions have been committed. At least you have any suggestion for the button command piece from repair VM button, this should be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants