Skip to content

aks bastion: correctly set the contents of the kubeconfig#9415

Merged
zhoxing-ms merged 2 commits into
Azure:mainfrom
stevekuznetsov:skuznets/aks-bastion-fix-kubeconfig
Nov 14, 2025
Merged

aks bastion: correctly set the contents of the kubeconfig#9415
zhoxing-ms merged 2 commits into
Azure:mainfrom
stevekuznetsov:skuznets/aks-bastion-fix-kubeconfig

Conversation

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@stevekuznetsov stevekuznetsov commented Nov 11, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 11, 2025 23:01
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Nov 11, 2025 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Nov 11, 2025

Hi @stevekuznetsov,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 11, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 11, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 11, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@stevekuznetsov stevekuznetsov force-pushed the skuznets/aks-bastion-fix-kubeconfig branch from b87cae3 to 6d5cfdf Compare November 11, 2025 23:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 11, 2025 •
edited
Loading

Hi @stevekuznetsov

Release Suggestions

Module: aks-preview

  • Update VERSION to 19.0.0b17 in src/aks-preview/setup.py

Notes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 11, 2025

Hi @stevekuznetsov

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 19.0.0b16 in src/aks-preview/setup.py

Notes

Copilot AI reviewed Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the AKS bastion kubeconfig update logic where modifications to cluster configurations were not being persisted to the YAML data structure that gets written to disk.

Key Changes:

  • Fixed kubeconfig update logic to modify the actual data structure instead of the loop variable
  • Added enumeration to access clusters by index in the data dictionary

@stevekuznetsov stevekuznetsov force-pushed the skuznets/aks-bastion-fix-kubeconfig branch from 6d5cfdf to a346fad Compare November 11, 2025 23:23
bennerv
bennerv approved these changes Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bennerv bennerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works as expected now.

FumingZhang
FumingZhang reviewed Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

Comment thread src/aks-preview/HISTORY.rst Outdated
@FumingZhang
Copy link
Copy Markdown
Member

FumingZhang commented Nov 11, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Nov 11, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@stevekuznetsov
aks bastion: correctly set the contents of the kubeconfig
7380c9a 
Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/aks-bastion-fix-kubeconfig branch from a346fad to 7380c9a Compare November 11, 2025 23:40
@FumingZhang
Copy link
Copy Markdown
Member

FumingZhang commented Nov 11, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Nov 11, 2025

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang
FumingZhang previously approved these changes Nov 11, 2025
View reviewed changes
@bennerv bennerv mentioned this pull request Nov 11, 2025
Open
@FumingZhang
Copy link
Copy Markdown
Member

FumingZhang commented Nov 12, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Nov 12, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 1ae78b4 into Azure:main Nov 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@FumingZhang FumingZhang FumingZhang left review comments

@andyliuliming andyliuliming Awaiting requested review from andyliuliming

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

@yonzhan yonzhan Awaiting requested review from yonzhan

@jsntcy jsntcy Awaiting requested review from jsntcy

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

@necusjz necusjz Awaiting requested review from necusjz

+1 more reviewer

@bennerv bennerv bennerv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@necusjz necusjz

@zhoxing-ms zhoxing-ms

@yanzhudd yanzhudd

Labels

AKS Auto-Assign Auto assign by bot Network

Projects

None yet

Milestone

December 2025 (2025-12-02)

Development

Successfully merging this pull request may close these issues.

8 participants

@stevekuznetsov @yonzhan @FumingZhang @bennerv @zhoxing-ms @necusjz @yanzhudd