Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @runzhen, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
Cleans up logic in the AKS preview agentpool update decorator around managed GPU updates, intended to remove “dead code” in the az aks update flow.
Changes:
- Removes idempotency short-circuit checks in
update_managed_gpuwhen the nodepool is already in the requested GPU management mode.
|
Hi @runzhen Release SuggestionsModule: aks-preview
Notes
|
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
It's better to add some tests and leave a history note about the change.
|
@FumingZhang I added the history. the existing test cases can cover the change, that's why it is dead code. |
Related command
az aks update
This PR only remove some dead code, no functional changes.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.