Skip to content

[confcom]: Fix accidental docker dependency even when using tar#9863

Merged
necusjz merged 4 commits into
Azure:mainfrom
micromaomao:tingmao/docker-tar
May 14, 2026
Merged

[confcom]: Fix accidental docker dependency even when using tar#9863
necusjz merged 4 commits into
Azure:mainfrom
micromaomao:tingmao/docker-tar

Conversation

@micromaomao
Copy link
Copy Markdown
Member

@micromaomao micromaomao commented May 13, 2026

This fix was authored by: Mahati Chamarthy mchamarthy@microsoft.com

The C-WCOW changes introduced earlier accidentally forced a check for Docker even on the codepath for --tar. Since --tar should not require Docker, this is a regression. This PR fixes it


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 13, 2026 08:15
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 13, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 13, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a regression in the confcom extension where Docker was being checked/required even when --tar is used (which should be a Docker-less path), and bumps the extension version accordingly.

Changes:

  • Route --tar scenarios around Docker-based platform validation by threading tar_mapping through policy-loading entry points.
  • Add platform validation after reading image config from tar (and enrich tar-derived image info with Os).
  • Bump extension version to 2.0.1 and document the fix in HISTORY.rst.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/confcom/setup.py Bumps extension version to 2.0.1.
src/confcom/HISTORY.rst Adds release notes entry for 2.0.1.
src/confcom/azext_confcom/security_policy.py Skips Docker-based platform validation when image is sourced from tar; validates platform after reading tar config.
src/confcom/azext_confcom/os_util.py Includes Os when mapping image config from tar.
src/confcom/azext_confcom/custom.py Passes tar_mapping through CLI entry points into policy loaders.

Comment thread src/confcom/azext_confcom/security_policy.py
Comment thread src/confcom/azext_confcom/security_policy.py
@micromaomao
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 9863 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 13, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit 0445abb into Azure:main May 14, 2026
23 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/msazure/One/_build/results?buildId=164108814&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants