az dls fs download should return message from service side instead of CLI core

[yungezz]

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
when user run az dls fs download command, the command failed because file/dir not exists. While the exception/stacktrace is confusing, because it's from CLI core. pls see below. The error is not from service side although it supposed to when file/dir not exists. Missing clear info from service side error message makes trouble shooting less informative, and causes user confusion. Need to refine it.

az dls fs download -n bkwndtl --overwrite --destination-path /mnt/glm/ --source-path '/clusters/ETAP-Cluster/simulation2/*/*.glm'
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
sh: 0: getcwd() failed: No such file or directory
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/az/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/__main__.py", line 33, in <module>
    az_cli = get_default_cli()
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 547, in get_default_cli
    from azure.cli.core.azlogging import AzCliLogging
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/azlogging.py", line 30, in <module>
    from azure.cli.core.commands.events import EVENT_INVOKER_PRE_CMD_TBL_TRUNCATE
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 28, in <module>
    from azure.cli.core.extension import get_extension
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/extension/__init__.py", line 16, in <module>
    az_config = CLIConfig(config_dir=GLOBAL_CONFIG_DIR, config_env_var_prefix=ENV_VAR_PREFIX)
  File "/opt/az/lib/python3.6/site-packages/knack/config.py", line 50, in __init__
    current_dir = os.getcwd()
FileNotFoundError: [Errno 2] No such file or directory

To Reproduce
Steps to reproduce the behavior.

Expected behavior
A clear and concise description of what you expected to happen.

Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)

Additional context
Add any other context about the problem here.

[yungezz]

HI @Juliehzl I'm not sure the right owner. Could you pls help to reassign if you're not right contact point? Thanks.

[yonzhan]

The same issue mentioned in Sev 3: ID 175946000: [bkw.ch][sev B][120021222002848 - Since 2020 the "az dls fs"command don't seem to work properly, right?

[yungezz]

more info from service team about the exception from service side when downloading failure:
https://github.com/Azure/azure-data-lake-store-python/blob/d7293c7690870bf730f3001ac64933a4183d9e8d/azure/datalake/store/exceptions.py#L32

[yonzhan]

We will take a look and follow up, thx.

[Juliehzl]

@akharit Can you take a look for this issue?

[akharit]

I am not sure if this is an adls issue as there doesn't seem to be dls module in the stack trace.

The stack trace shows

    current_dir = os.getcwd()
    FileNotFoundError: [Errno 2] No such file or directory

This means the current dir in the according to python was somehow deleted.

It is possible that adls destination path was specified in such a way to delete the current dir, but I would classify that as a user error. It could have been deleted by any other user process as well.

If a fix is needed, we possibly need to open a bug on knack module.

[mmyyrroonn]

@jiasli I had a try and it's indeed a quite weird corner case for knack. I don't know whether we can fix it or not. You can take a look.