Autogenerated help example is wrong for `az aks enable-addons`

[mikkelhegn]

This is autogenerated. Please review and update as needed.

The example in the help message of this command is wrong, and since it's autogenerated, I'm not sure how to commit a fix.

Command Name
az aks enable-addons

Errors:
This is the example

Examples
Enable Kubernetes addons. (autogenerated)
az aks enable-addons --addons virtual-node --name MyManagedCluster --resource-group
MyResourceGroup

This is further up the help message, describing that --subnet is a required parameter:

virtual-node - enable AKS Virtual Node (PREVIEW). Requires --subnet-name to provide the
name of an existing subnet-name for the Virtual Node to use.

To Reproduce:

Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

• Put any pre-requisite steps here...
• az aks enable-addons --help

Expected Behavior

The example show that --subnet-name is required

Environment Summary

Linux-4.19.104-microsoft-standard-x86_64-with-debian-buster-sid
Python 3.6.5

azure-cli 2.2.0 *

Additional Context

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/aks-pm.

[yonzhan]

aks

[mikkelhegn]

I'm on the AKS team - do we control how this get autogenerated?

[yonzhan]

@haroldrandom to check whether it is autogenerated by Aladdin.

[Jen7714]

@haroldrandom any updates here?

[haroldrandom]

@Jen7714 Sorry for the late reply.

Yes, this example is auto generated one year ago.

azure-cli/src/azure-cli/azure/cli/command_modules/acs/_help.py

Lines 489 to 492 in 5fe403f

	examples:
	- name: Enable Kubernetes addons. (autogenerated)
	text: az aks enable-addons --addons virtual-node --name MyManagedCluster --resource-group MyResourceGroup
	crafted: true

Currently, we collabrate with Aladdin team, the will auto generate examples for Azure CLI, we review and merge them, then provide feedback to Aladdin to help to improve the AI who generates examples.

You could search PR like this #13492. Those examples are all prvoided by Aladdin automatically. We have merged serveral PRs like this.

We are testing this process internally, just for some of commands Azure CLI own. Once we think Aladdin provide examples are more stable, we will open more commands for you guys to review which include aks/acs of course.

Currently, we have to fix it manually. Could you create a PR to improve it?

[mikkelhegn]

Did anyone pick up this? Could you create a PR to improve it?

[haroldrandom]

@mikkelhegn You could ping me as assignee, then we revert what Aladdin did or put on what you think is correct.

[mikkelhegn]

@haroldrandom - not sure I understand your latest update. Do you want me to submit a PR with the change and assign the PR to you as a reviewer?

[haroldrandom]

not sure I understand your latest update. Do you want me to submit a PR with the change and assign the PR to you as a reviewer?

Yeah.