Move VM Image List off of GitHub #4611
Description
Notice in the cloud.py, we have a hardcoded path to a file hosted in github. It means every time users execute az vm image list, the command will fetch the file from raw.githubusercontent.com. This render a few issues:
- Why do we rely on a third party to host files for runtime execution?
- Github is not a file share service. It is a source control service. That means the url we relies on is not 100% reliable.
- Github can throttle the access to this file just like they throttle the release files, which will break our command.
- Github can be blocked in some subnet or behind a firewall, which will make this command unusable.
- Github won’t guarantee the performance of this file host.
I understand that the logic behind this is that this fire will be updated after CLI is released so as to keep to the latest image types list. However, we should have this file publish to a storage account under our control to guarantee the user experience.
endpoints=CloudEndpoints(
| management='https://management.core.windows.net/',
| resource_manager='https://management.azure.com/',
| sql_management='https://management.core.windows.net:8443/',
| batch_resource_id='https://batch.core.windows.net/',
| gallery='https://gallery.azure.com/',
| active_directory='https://login.microsoftonline.com',
| active_directory_resource_id='https://management.core.windows.net/',
| active_directory_graph_resource_id='https://graph.windows.net/',
| active_directory_data_lake_resource_id='https://datalake.azure.net/',
| vm_image_alias_doc='https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/quickstart-templates/aliases.json'), # pylint: disable=line-too-long
|