CI Failing to Download Artifacts

[marstr]

PR Validation Broken

Yesterday afternoon (June 11th,) our CI pipeline started sporadically experiencing failure to download some build artifacts. This is causing PR validation to fail consistently. We have reached out to the Azure DevOps team, but do not currently have an ETA for a fix. Information will be posted here as we learn more.

[marstr]

After chatting with @mitchdenny, who is a subject matter expert on Azure DevOps, we've confirmed that these failures are stemming from an issue with DevOps itself. Likely, we are dogfooding a recently released artifacts-engine version that is troubled. To work around this, we're adopting newer tasks. PublishBuildArtifact -> PublishPipelineArtifact, DownloadBuildArtifact -> DownloadPipelineArtifact. In #9650, that conversion is started. However, there are a couple of places left to clean up.

[marstr]

The switch to the newer ADO tasks has been merged. This should unblock PRs. If we see continued failures, I'll reopen this issue.

In order to adopt these changes in a PR that you believe is failing because of this issue, please rebase/merge from the most recent version of dev which includes the commit d2cf98f.