Skip to content

[Compute] vmss create/update: add --enable-terminate-notification (only for update) and --terminate-notification-time parameters to support terminate scheduled event configurability. Issue #10124#10445

Merged
qwordy merged 8 commits into
Azure:devfrom
qwordy:dev
Sep 9, 2019

Conversation

@qwordy
Copy link
Copy Markdown
Member

@qwordy qwordy commented Sep 6, 2019

[Compute] vmss create/update: add --enable-terminate-notification (only for update) and --terminate-notification-time parameters to support terminate scheduled event configurability. Issue #10124

This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@qwordy
Copy link
Copy Markdown
Member Author

qwordy commented Sep 6, 2019

Original PR: #10391
I have to open a new PR due to some mistakes.

Comment thread src/azure-cli/azure/cli/command_modules/vm/_template_builder.py
Comment thread src/azure-cli/HISTORY.rst
* [BREAKING] When not specified, the default value for `--start-task-wait-for-success` on `az batch pool create` is now true (was false).
* [BREAKING] The default value for Scope on AutoUserSpecification is now always Pool (was Task on Windows nodes, Pool on Linux nodes). This argument is not exposed via the commandline, but can be set in the `--json-file` arguments.

**Compute**
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the output of the vmss show command?
Is it the json output of the response?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the output of the vmss show command?
Is it the json output of the response?

vmss show visit GET https://management.azure.com/subscriptions/{...}/resourceGroups/{...}/providers/Microsoft.Compute/virtualMachineScaleSets/{name}?api-version=2019-03-01.

Basically, Yes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, vmss get-instance-view visit GET https://management.azure.com/subscriptions/{...}/resourceGroups/{...}/providers/Microsoft.Compute/virtualMachineScaleSets/{name}/instanceView?api-version=2019-03-01

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between virtualMachineScaleSets/{name}?$expand=instanceView and virtualMachineScaleSets/{name}/instanceView?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

virtualMachineScaleSets/{name}?$expand=instanceView returns the vmScaleSet goal state with a property named instance view populated (instanceView is expensive runtime state)

virtualMachineScaleSets/{name}/instanceView just returns the expensive runtimestate without the vmScaleSet goal state infromation

@qwordy qwordy requested a review from zikalino September 9, 2019 01:43
Comment thread src/azure-cli/azure/cli/command_modules/vm/_params.py
@mmyyrroonn
Copy link
Copy Markdown
Contributor

mmyyrroonn commented Sep 9, 2019

just one question. Does it support the time more than 60 minutes?

@qwordy
Copy link
Copy Markdown
Member Author

qwordy commented Sep 9, 2019

just one question. Does it support the time more than 60 minutes?

just one question. Does it support the time more than 60 minutes?

Server has limitation. 5~15 min.

Comment thread src/azure-cli/azure/cli/command_modules/vm/_params.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants