AppService: Updating to use the latest version of SDK #11476

panchagnula · 2019-12-04T20:57:05Z

Fixes #10476

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.

panchagnula · 2019-12-04T21:04:39Z

@qwordy can you help me figure out what is missing here since i see this error in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Juliehzl · 2019-12-05T06:46:02Z

Hi @panchagnula, according to your code change in the PR, you plan to upgrade the azure-mgmt-web to 0.44.0, and I will assume you want to use v2019-08-01 for AppService related commands. Is this you expected? And I am working on MultiAPI support for AppService and I think I can upgrade the api version for you.

panchagnula · 2019-12-05T09:36:41Z

I think the multi-api version is taking longer than expected because the v2019-08-01 is not supported for hybrid & if we can just do the update to use the new SDK directly first & then figure out the multis-api support that would be great. let me know if this is something you can take care of. Thanks Sisira Sent from Outlook<http://aka.ms/weboutlook>

…

________________________________ From: Zunli Hu <notifications@github.com> Sent: Wednesday, December 4, 2019 22:46 To: Azure/azure-cli <azure-cli@noreply.github.com> Cc: Sisira Panchagnula <sisirap@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-cli] AppService: Updating to use the latest version of SDK (#11476) Hi @panchagnula<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpanchagnula&data=02%7C01%7Csisirap%40microsoft.com%7C30152cbb801546ae6f3408d7794ecccc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637111251661225638&sdata=DeCOGeu9VoVvV6C%2FTsxqpb4%2FpvLDRyxdRTc1DBE0DV8%3D&reserved=0>, according to your code change in the PR, you plan to upgrade the azure-mgmt-web to 0.44.0, and I will assume you want to use v2019-08-01 for AppService related commands. Is this you expected? And I am working on MultiAPI support for AppService and I think I can upgrade the api version for you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli%2Fpull%2F11476%3Femail_source%3Dnotifications%26email_token%3DADJSYDC5M37GDZLZTSPU4RLQXCPSXA5CNFSM4JVOSNLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7V5MA%23issuecomment-561995440&data=02%7C01%7Csisirap%40microsoft.com%7C30152cbb801546ae6f3408d7794ecccc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637111251661225638&sdata=1gyV9dmsI8ZbQBQHY5qwGZCyShGkNw%2BIXesRYHltaQk%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADJSYDHWJIAXTNNIZHUOGG3QXCPSXANCNFSM4JVOSNLA&data=02%7C01%7Csisirap%40microsoft.com%7C30152cbb801546ae6f3408d7794ecccc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637111251661235594&sdata=AEvyO92kcGseKAeNugoIr99hHVAhSOvntfkIEpzRwSo%3D&reserved=0>.

qwordy · 2019-12-10T01:36:07Z

@qwordy can you help me figure out what is missing here since i see this error in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Try azdev setup -c -r azure-cli-extensions/ to install dependencies correctly. I have met this kind of error, too.

Juliehzl · 2019-12-12T05:36:32Z

I think the multi-api version is taking longer than expected because the v2019-08-01 is not supported for hybrid & if we can just do the update to use the new SDK directly first & then figure out the multis-api support that would be great. let me know if this is something you can take care of.

Thanks
Sisira

Sent from Outlookhttp://aka.ms/weboutlook
…

Got it!

yonzhan · 2019-12-15T13:13:02Z

add to S163.

Juliehzl · 2019-12-22T13:34:21Z

Hi @panchagnula are you still working on this?

panchagnula · 2019-12-31T08:18:28Z

@Juliehzl / @qwordy/ @yonzhan my current changes should take care of supporting Multi-api support as well however, I cannot figure out the cause for the build failure - can one of you help me here please? Thank you.

qwordy · 2019-12-31T08:34:57Z

@qwordy can you help me figure out what is missing here since i see this error in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Is it still this error blocking you?
I've seen the error in CI. ModuleNotFoundError: No module named 'azure.mgmt.web.v2019_08_01.web_site_management_client'

panchagnula · 2019-12-31T21:26:33Z

@qwordy can you help me figure out what is missing here since i see this error in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Is it still this error blocking you?
I've seen the error in CI. ModuleNotFoundError: No module named 'azure.mgmt.web.v2019_08_01.web_site_management_client'

I figured out the issue - took some time to debug - but I think I got it now. Couple more failing tests but after that I should be good to go.

panchagnula · 2020-01-03T22:49:40Z

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680

I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!

that needs to be re-recorded

Juliehzl · 2020-01-06T01:53:20Z

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680

I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!

that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680

I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!

that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

panchagnula · 2020-01-06T04:45:00Z

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks - let me know when the fix is in dev I will pull & rebase.

Juliehzl · 2020-01-06T14:27:21Z

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks - let me know when the fix is in dev I will pull & rebase.

you can rebase dev branch now. if there is still problem, feel free to let me know.

panchagnula · 2020-01-08T22:20:12Z

@Juliehzl any update on this please? Thanks!

Juliehzl · 2020-01-09T03:04:39Z

@Juliehzl any update on this please? Thanks!

You can rebase the dev now and re-record for the test. I think it should work now.

panchagnula · 2020-01-09T06:49:13Z

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks - let me know when the fix is in dev I will pull & rebase.

you can rebase dev branch now. if there is still problem, feel free to let me know.

Tried this & still the same error when trying to re-record raise CLIError('{} {}'.format(message, code))
E knack.util.CLIError: Unable to find the resource /subscriptions/e483435e-282d-4ac1-92b5-d6123f2aa360/resourceGroups/cli_test_metric_alert_v23gguxyyliai35ejxeklzrm6ujtf6jxegub4epaxunzrtchixrw7/providers/Microsoft.Storage/storageAccounts/clitestwgbiozzwakiu5pd3p, please confirm that it exists.. [Code: "BadRequest"] .

panchagnula · 2020-01-09T08:17:11Z

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks - let me know when the fix is in dev I will pull & rebase.

you can rebase dev branch now. if there is still problem, feel free to let me know.

Tried this & still the same error when trying to re-record raise CLIError('{} {}'.format(message, code))
E knack.util.CLIError: Unable to find the resource /subscriptions/e483435e-282d-4ac1-92b5-d6123f2aa360/resourceGroups/cli_test_metric_alert_v23gguxyyliai35ejxeklzrm6ujtf6jxegub4epaxunzrtchixrw7/providers/Microsoft.Storage/storageAccounts/clitestwgbiozzwakiu5pd3p, please confirm that it exists.. [Code: "BadRequest"] .

This test needs to be re-recoded with this change since this use Appservice plan command the api-version of which has been updated in this PR. Can I disable this test as a part of this, merge these & someone from the core team re-record this once this is in dev? Please let me know - this has been sitting in PR forever.

yonzhan · 2020-01-10T01:54:47Z

@Juliehzl please merge this PR by this week.

Juliehzl · 2020-01-13T03:06:03Z

Hi @panchagnula, can you use az webapp deployment user show correctly?

…pi support Adding new file Re-recording webjobs tests Adding Yaml files Re-running tests Removing incorrect tests & add new recording Updating requirements files recording Linux test on MAC Adding recording for Identity file Removing reservedInstanceCount since its no longer supported with new API-version PyLint fixes Adding recording for failing tests Adding recording Updating clientFacotory Updating reference to APPService MGMT_Client Fixing linter to find the client_management operations Adding recording Updating to use an api-version that has website_client_management Updating to use 2018-02-01 as the api-version Fixing mock tests after using multi-api SDK support Recording bot tests after webapp sdk update Updating history Recording for failing bot test Fixing history

panchagnula · 2020-01-13T07:51:13Z

Hi @panchagnula, can you use az webapp deployment user show correctly?

haven't checked will take a look. Is there a reason you are checking this? Is there some known issue you are aware of? Thanks!

panchagnula · 2020-01-16T07:18:35Z

closing this since this is was covered by #11056

panchagnula requested a review from qwordy as a code owner December 4, 2019 20:57

panchagnula added this to the S162 milestone Dec 4, 2019

haroldrandom assigned panchagnula Dec 10, 2019

yonzhan requested a review from Juliehzl December 10, 2019 07:29

panchagnula force-pushed the sisirap-newSDKAppService branch from f60f67c to 00ad011 Compare December 13, 2019 01:29

yonzhan modified the milestones: S162, S163 Dec 15, 2019

yonzhan assigned Juliehzl Dec 15, 2019

panchagnula force-pushed the sisirap-newSDKAppService branch from 00ad011 to ddf20ce Compare December 30, 2019 07:37

panchagnula requested a review from jiasli as a code owner December 30, 2019 07:37

panchagnula force-pushed the sisirap-newSDKAppService branch 3 times, most recently from b0d1dea to 463dc29 Compare December 31, 2019 00:47

panchagnula modified the milestones: S163, S164 Dec 31, 2019

panchagnula force-pushed the sisirap-newSDKAppService branch 3 times, most recently from 5e5841b to be764e3 Compare December 31, 2019 06:25

panchagnula force-pushed the sisirap-newSDKAppService branch 2 times, most recently from 288a0af to 7d2e124 Compare January 2, 2020 19:59

panchagnula force-pushed the sisirap-newSDKAppService branch 3 times, most recently from e2fb1ab to fd57199 Compare January 3, 2020 20:32

panchagnula force-pushed the sisirap-newSDKAppService branch from fd57199 to e539052 Compare January 9, 2020 06:50

panchagnula force-pushed the sisirap-newSDKAppService branch from e539052 to 140ea1f Compare January 13, 2020 07:13

panchagnula force-pushed the sisirap-newSDKAppService branch from 140ea1f to ff4d6ad Compare January 13, 2020 07:30

panchagnula closed this Jan 16, 2020

panchagnula deleted the sisirap-newSDKAppService branch January 16, 2020 07:18

AppService: Updating to use the latest version of SDK #11476

AppService: Updating to use the latest version of SDK #11476

Uh oh!

Conversation

panchagnula commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes #10476

Uh oh!

panchagnula commented Dec 4, 2019

Uh oh!

Juliehzl commented Dec 5, 2019

Uh oh!

panchagnula commented Dec 5, 2019 via email

Uh oh!

qwordy commented Dec 10, 2019

Uh oh!

Juliehzl commented Dec 12, 2019

Uh oh!

yonzhan commented Dec 15, 2019

Uh oh!

Juliehzl commented Dec 22, 2019

Uh oh!

panchagnula commented Dec 31, 2019

Uh oh!

qwordy commented Dec 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panchagnula commented Dec 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panchagnula commented Jan 3, 2020

Uh oh!

Juliehzl commented Jan 6, 2020

Uh oh!

panchagnula commented Jan 6, 2020

Uh oh!

Juliehzl commented Jan 6, 2020

Uh oh!

panchagnula commented Jan 8, 2020

Uh oh!

Juliehzl commented Jan 9, 2020

Uh oh!

panchagnula commented Jan 9, 2020

Uh oh!

panchagnula commented Jan 9, 2020

Uh oh!

yonzhan commented Jan 10, 2020

Uh oh!

Juliehzl commented Jan 13, 2020

Uh oh!

panchagnula commented Jan 13, 2020

Uh oh!

panchagnula commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

panchagnula commented Dec 4, 2019 •

edited

Loading

qwordy commented Dec 31, 2019 •

edited

Loading

panchagnula commented Dec 31, 2019 •

edited

Loading