[AKS] az aks use-dev-spaces: Adding endpoint type option to use-dev-spaces command to customize the endpoint created on a controller by rakeshvanga · Pull Request #12028 · Azure/azure-cli

rakeshvanga · 2020-02-04T01:43:20Z

History Notes:
[ACS] az aks use-dev-spaces: Adding endpoint type option to the use-dev-spaces command to customize the endpoint created on an Azure Dev Spaces controller.

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.

yonzhan · 2020-02-04T01:53:10Z

add to S165.

src/azure-cli/azure/cli/command_modules/acs/custom.py

amsoedal

Lgtm!

sanar-microsoft · 2020-02-20T20:30:09Z

/azp run

azure-pipelines · 2020-02-20T20:30:14Z

Commenter does not have sufficient privileges for PR 12028 in repo Azure/azure-cli

sanar-microsoft · 2020-02-20T20:30:54Z

@qwordy Can you please trigger the build pipeline again? Thanks

rakeshvanga · 2020-02-20T20:31:24Z

/azp run

azure-pipelines · 2020-02-20T20:31:29Z

Commenter does not have sufficient privileges for PR 12028 in repo Azure/azure-cli

rakeshvanga · 2020-02-21T00:24:48Z

@qwordy The test cases failing are not related to the changes in this PR. So can you re-run the pipeline?

qwordy · 2020-02-21T06:05:54Z

/azp run

azure-pipelines · 2020-02-21T06:06:17Z

Azure Pipelines failed to run 1 pipeline(s).

rakeshvanga · 2020-02-21T20:05:28Z

@qwordy Thanks for re-running the pipeline.
The pipeline failed with following error:

Pipeline configuration error:
Job CredScan: Step task reference is invalid. The task name CredScan is ambiguous. Specify one of the following identifiers to resolve the ambiguity: ea576cd4-c61f-48f8-97e7-a3cb07b90a6f, e587fa4a-fc98-44fd-ab3e-ddaa3025219a
Job CredScan: Step task reference is invalid. The task name PostAnalysis is ambiguous. Specify one of the following identifiers to resolve the ambiguity: f5679091-e6da-4974-a8dc-0eec03a8ea63, 18ff34ab-7385-4b57-b5d5-a0fcc7b5b274

Can this PR be merged by-passing this check? Or can you help resolve this pipeline issue?

qwordy · 2020-02-24T03:25:28Z

@qwordy Thanks for re-running the pipeline.
The pipeline failed with following error:

Pipeline configuration error:
Job CredScan: Step task reference is invalid. The task name CredScan is ambiguous. Specify one of the following identifiers to resolve the ambiguity: ea576cd4-c61f-48f8-97e7-a3cb07b90a6f, e587fa4a-fc98-44fd-ab3e-ddaa3025219a
Job CredScan: Step task reference is invalid. The task name PostAnalysis is ambiguous. Specify one of the following identifiers to resolve the ambiguity: f5679091-e6da-4974-a8dc-0eec03a8ea63, 18ff34ab-7385-4b57-b5d5-a0fcc7b5b274

Can this PR be merged by-passing this check? Or can you help resolve this pipeline issue?

Related code: https://github.com/Azure/azure-cli/blob/dev/azure-pipelines.yml#L36
@haroldrandom @fengzhou-msft Can you help with this problem? Thanks a lot!

haroldrandom · 2020-02-24T06:29:16Z

/azp run

azure-pipelines · 2020-02-24T06:29:25Z

Azure Pipelines successfully started running 1 pipeline(s).

haroldrandom · 2020-02-24T07:03:45Z

@rakeshvanga your branch is way too behind dev branch, could you please rebase/merge your branch against the last commit of dev?
I guess it's causing something weird in ADO such that we cannot read the detailed output of this build :(

qwordy · 2020-02-24T11:52:33Z

@rakeshvanga your branch is way too behind dev branch, could you please rebase/merge your branch against the last commit of dev?
I guess it's causing something weird in ADO such that we cannot read the detailed output of this build :(

Do you mean CI will use pipeline definition in PR instead of dev branch?

rakeshvanga · 2020-02-25T07:06:11Z

@rakeshvanga your branch is way too behind dev branch, could you please rebase/merge your branch against the last commit of dev?
I guess it's causing something weird in ADO such that we cannot read the detailed output of this build :(

Sure I have updated my branch and pushed new changes

haroldrandom · 2020-02-25T08:18:50Z

@rakeshvanga your branch is way too behind dev branch, could you please rebase/merge your branch against the last commit of dev?
I guess it's causing something weird in ADO such that we cannot read the detailed output of this build :(

Sure I have updated my branch and pushed new changes

CI is fine. Good to go. @qwordy

* {Misc.} Update CODEOWNERS (Azure#12149) * {Packaging} Update version management policy (Azure#12095) * [AppConfig]Add customer managed key when updating stores. (Azure#12102) * {Network} Connection Monitor V2 feature (Azure#12140) * [Compute] BREAKING CHANGE: Fix Azure#10728: `az vm create`: create subnet automatically if vnet is specified and subnet not exists (Azure#12115) * [Compute] Fix Azure#10728: `az vm create`: create subnet automatically if vnet is specified and subnet not exists * {Compute} update test_vm_commands to fix merge conflict * {Compute} fix test recording file for profile hybrid_2018_03_01 & hybrid_2019_03_01 * {Compute} update subnet help message & fail to create error message * {Compute} update fail to create subnet error message * {Compute} update test recording due to merge conflict * [Aladdin] Parse generated examples into commands' _help.py (Azure#11716) * [Compute] Increase robustness of vm image list (Azure#12134) * {KeyVault} Modify command group name `private-endpoint` to `private-endpoint-connection` (Azure#12151) * {Compute} Add missing parameter to attach disk example command (Azure#12045) attaching unmanaged disk without --name will cause error fix the example by adding `--name MyDataDisk` * [AppService] Add support for v3 function apps and node 12. (Azure#11987) * [functionapp] Add support for v3 function apps and node 12. * Changed --version to --functions-version to help clarify version flags. Added functions version to invalid runtime version error. * Fixed styling. * [AppService] az webapp list-runtimes: Fix the bug for list-runtimes (Azure#12172) * fix positional argument * add test for test_webapp_runtimes * {Packaging} Get rid of psutil dependency (Azure#11665) * {Release} Auto generate history notes (Azure#12098) * [AppService] az webapp|functionapp config ssl create: Add new commands to support create certificate (Azure#11955) * Support for Managed Certificate * Adding slot support * Added unit test * History change * Remove history - part of PR description now * Block calls for Free and Shared tier * Update unit test * Rename command to create * Fix to error text * {Packaging} Remove Python 2 in setup and doc (Azure#12155) * {Core} use caseless matching for provisioning_state (Azure#12154) * Fix az group deployment create has an error when using large parameters.json file (Azure#12047) * [ACR] `az acr login`: Throw a CLIError if there are errors returned by docker command (Azure#12156) * [Backup] Fix for item level recovery flow in OLR (Azure#12118) * Fix for item level recovery flow in OLR * style fix * [Backup] az backup recoveryconfig show: Add more parameters to support restoring as files for SQL/SAP Hana (Azure#12116) * initial commit * updated tests * updated history.rst * cli style fix * {Release} Upgrade to Azure CLI 2.1.0 (Azure#12195) * update azure-cli version to 2.1.0 * Update HISTORY.rst * {Package} remove requirements.py of python2 * Update commands.py Co-authored-by: Xiaojian Xu <arrownj@126.com> * [ARM] az resource: Improve the examples of the resource module (Azure#11981) * {CI} Remove files related to Travis only (Azure#12203) * {Monitor} az monitor autoscale create: add example for custom rule based on guest os. (Azure#12205) * {azdev} Remove urllib3==1.24.2 from requirements.txt (Azure#12211) * [AKS] fix the aks browse in cloud shell. (Azure#12174) * {Storage} az storage share-rm: Add process_resource_group for resource group (Azure#12232) * add validator=process_resource_group * refine storage account validator * add more validate * [AKS] az aks: Fix monitoring addon and agentpool NoneType errors. (Azure#12250) * {SignalR} Fix show command fails with unexpected error when the resource doesn't exist (Azure#12266) * Do not copy tests dirs in docker image (Azure#12208) * [Storage] az storage blob delete-batch: Misbehaving `--dryrun` flag (Azure#12162) * [Storage] az storage blob delete-batch: Misbehaving `--dryrun` flag * [Storage] az storage blob delete-batch: Misbehaving `--dryrun` flag * [ACR] Fix: `az acr login` wrongly raise error (Azure#12282) * [Network] az network application-gateway rewrite-rule create: support url configuration (Azure#12277) * [Network] az network dns zone import: --zone-name will be case insensitive in the future. (Azure#12264) * fix (Azure#12300) * [AppService] Fix Azure#2258: Fixing issue where trying to create a webapp with certain runtimes was failing (Azure#12260) * Fixing issue where trying to create a webapp with certain runtimes was failing updating history Upating to make sure NODE works as well when trying to set app_Settings Pylint fixes * Adding test & re-recording * Removing the formatting changes to keep the changes to just the bug fix * {Network} Supplemnt help message of --source-address-prefixes and --destination-address-prefixes for nsg rule creation (Azure#12321) * {doc} Add Import Directive from docutils.parsers.rst for old API deprecation (Azure#12295) sphinx.util.compat is deprecated since 1.6 and removed in 1.7. * {Document} update install troubleshooting (Azure#12230) * {Network} Fix wrong import ZoneType of DNS (Azure#12322) * update codeowners (Azure#12201) * {Storage} Change api version range for storage account kind (Azure#12265) * change min_api * change test * [CosmosDB] Add Sql stored procedure, udf and trigger cmdlets (Azure#11999) * Added cosmosDB sql stored procedure, udf and trigger cmdlets * added help, fixed indentation, fixed wrong code * fixed a typo * indentation fix * flake8 issues fixed * PR comments * changed help accordingly * style fix * change in help msg * [ACS] (BREAKING CHANGE:) (az aks:) support msi changes for GF and BF for omsagent (Container monitoring)(#1) (Azure#12100) * [ARM] az policy assignment list: Support listing policy assignments at Management Group scope (Azure#12086) * Support listing policy assignments at MG scope * Fix test recording * Fix bug and add test case * {Packaging/Ubuntu} remove cosmic packaging (Azure#12330) * {Container monitoring} - Add case insensitive string compare for msi string (Azure#12341) * [KeyVault] keyvault create: enable soft-delete by default (Azure#12204) * make PE and PLS GA (Azure#12326) * [Network]az network bastion: support bastion (Azure#12331) * [AKS] az aks use-dev-spaces: Adding endpoint type option to use-dev-spaces command to customize the endpoint created on a controller (Azure#12028) * [AKS] add tag for nodepool (Azure#12145) * {Packaging/Homebrew} Remove patch when upgrade (Azure#12344) * {Find} az find: Remove EUII (Azure#12349) * delete azure-cli-extension (Azure#12362) * [Compute] sig image-version: add --data-snapshot-luns (Azure#12303) * [AppService] functionapp: Added error message to deployment command if resource group/function name invalid (Azure#12318) * [AppService] fixing flag cited in warning message (Azure#12364) * [ARM] Refactor deployment commands (Azure#10751) * update SDK version. * Refactor az deployment commands. * record tests. * test recordings. * [ACR] Add new command `az acr helm install-cli` (Azure#12336) * [Network] az network vnet list-available-ips: support list available ips in a vnet (Azure#12371) * Validate ip-address parameter + tests (Azure#12312) * [AppService] functionapp: Updated container image configuration for Linux apps (Azure#12317) * Updated linuxFxVersion configuration for linux apps. * Fixed HISTORY.rst, improved error message for invalid runtimes. * Changed how linuxFxVersion is handled for dotnet. Renamed constants for increased clarity. * [Network] Add new commands to manage flow-log and deprecate old configure command (Azure#12350) * {Packaging/windows pip} Use local python for az.bat (Azure#12323) * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent (Azure#12327) * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [AKS] Add support of creating private cluster (Azure#12353) * [SQL] Sql midb Add: list-deleted, show-deleted, update-retention, show-retention (Azure#12033) * Adding support for short term retention and deleted database for MI * Fixing help file * Fixing help file * Updating tests * Adressing comments * Fixing style errors * Fixing help files * Fixing help files * Resyncing required for tests * Chaning deletion-time to deleted-time * More details in description on retention_days * Adressing comments * {KeyVault} Fix the case sensitive issue while running commands without specifying resource group name (Azure#12405) * {Storage} az storage file copy start: add examples for snapshot Azure#12410 * {Documentation}Command guideline for private endpoint connection and private link resource (Azure#12403) * [AKS] add support for creation time node labels (Azure#12418) * move propagate_env_change.exe to storage account (Azure#12401) * {Telemetry} Disable telemetry for some clouds (Azure#12400) * [Storage] az storage account create/update: Add Routing Preference support (Azure#12309) * add routing preferences * add test * fix style and rerun test * add tests and refine code * Add test for false * {Monitor}show command should return 3 (Azure#12404) * {Find} Suppress old find extension (Azure#12432) * [Storage] Upgrade azure-mgmt-storage version to 8.0.0 (Azure#12437) * [ACR]: private link and CMK support (Azure#12381) * [AppService] Fix Azure#12251 app settings race condition during zip deploy (Azure#12262) * Acr: remove private .wheel file (Azure#12450) * [RDBMS] Support Private Endpoint Connections (Azure#12394) * [Compute] ppg show: add --colocation-status to Enable fetching the colocation status of all the resources in the proximity placement group (Azure#12248) * [Compute] vm/vmss/availability-set update: add --ppg to allowing updating ProximityPlacementGroup * stage * add test * Add help; Support translataion from name to ID * [Compute] ppg show: add --colocation to Enable fetching the colocation status of all the resources in the proximity placement group * Add test * update parameter name * test * revolve some comments * Update parameter * compute 11.0.0 * test * fix test * fix * {Compute} fix none check when list vmss extension. (Azure#11914) * [AKS] add missing / in the dashboard url. (Azure#12411) * add allowProtectedAppendWrite (Azure#12448) * [Monitor] az monitor metrics alert create: support `~` in `--condition`. (Azure#12439) * update codeowners (Azure#12453) * Improve the help of az policy assignment create (Azure#12343) * Fix the bug that automatically generated name of policy assignment exceeds the limit (Azure#12352) * [Cosmos DB] az cosmosdb create: add --key-uri to support adding key vault encryption information (Azure#12417) * adding key-value-key-uri to cosmos db * remove history note * update package in requirements * remove whitespace on blank line * remove whitespace from blank line * add preview flag and update test * re-running tests with new API version * rename new parameter * [ARM] az group deployment create: Add parameter `--aux-tenants` to support cross tenants (Azure#11765) (Azure#12221) * Add parameter --aux-tenants to support cross tenants for az group deployment create * Add cross tenant support to the refactored deployment group create * [ACR] add 'private-link-resource list' command (Azure#12454) * {Documentation}fix documenttation (Azure#12435) * [AKS] Support create aks clusters enabling managed identity (Azure#12420) * Support create aks clusters enabling managed identity * Remove 'preview' * Add test case for AKS using managed identity * [CDN] Add CDN WAF commands (Azure#12071) * [Core] az cloud show: add insights telemetry channel endpoint for China/US cloud (Azure#12442) * [Storage] Add support for private link resource (Azure#12383) * initialize privete link for storage * refine command with help * refine help * pass test_storage_account_private_link * add exception handler * add exception handler * pass test * fix style * change list-private-link-resource to private-link-resource list * fix style and linter * apply validator and transform in core * enabled id_part for private linke resource list * remove previous validator and transform in storage * fix style * pass test * add ids for private link resource list * resolve comments * remove --ids to make linter pass * [Compute] az vmss create/update: support automatic repairs (Azure#12374) * [Compute] az vmss create/update: support automatic repairs * {Compute} fix automatic repairs style error * {Compute} update help message for --automatic-repairs-grace-period * {Compute} update validator error message for automatic repairs * {Compute} add automatic repairs arg group in vmss update * {Compute} fix sytle error in _params.py * [AKS] Validate network plugin to be either "azure" or "kubenet". (Azure#12376) * [AppService] Fix #5720946: az webapp backup fails to set name (Azure#11929) * Fix backup name set functionality * Add test for backup * changes to meet checkstyles * add recording * [RBAC] az ad group show: fix --group value treated as regex problem (Azure#12426) * [RBAC] az ad group show: fix --group value treated as regex problem * {RBAC} update syntax error of error message * {RBAC} retrieve domain from az ad signed-in-user show instead of hard code * {RBAC} refactor validate_group function * {RBAC} update recording file for test_graph_group_idempotent * {RBAC} update test_graph * {RBAC} update test_graph to use the right user info Co-authored-by: Xiaojian Xu <xiaojxu@microsoft.com> * [Storage] Add PITR support (Azure#12372) * add action for blob range * add -t for time_to_restore * add restore_policy properties * rename restore_retention_days to restore_days * try to add test * add support_no_wait * refine test * fix style * enable no wait for restore * pass live test * fix comments and make blob range opetional * fix style * {KeyVault} Modify private link commands to align with storage (Azure#12457) * {Core} Change help example hook (Azure#12431) * [AKS] Add aad session key support. (Azure#12290) * {Release} use pat for github requests (Azure#12474) * {Packaging} bump up pyyaml (Azure#12440) * [RDBMS] Updating RDBMS Private Endpoint Tests (Azure#12475) * [Compute] image builder create: add --image-template\n[Compute] [BREAKING CHANGE] image template: rename template to builder (Azure#11865) * Add test for latest profile * [Compute] image template create: add --customize and --distribute * Add history * Fix style * Update test * rename template to builder * update help * add image_template * --image-template * test * remove --customize and --distribute * try-catch json error * help * fix style * fix a bug; update help * test of local file * Add example * error handle * help * [SQL] az sql server create/update: Add --enable-public-network to support PublicNetworkAccess (Azure#12382) * Add PublicNetworkAccess to Create and Update Server * Fix some styling + rerecorded tests * Fix more CLI style * Cleaned up code according to comments * Change public-network-access to enable-public-network * Bump up azure-mgmt-sql version * Rerecorded a couple of failing tests * Rerecord a couple more tests * Forgot to update test_sql_commands * Rerecord another test * Updating more tests * Small changes + more rerecorded tests * Fix style check errors * Random small change to rerun tests * Replace API versions * Fix style * [SQL DB, SQL MI] Add minimal_tls_version property for MI and SQL DB (Azure#12414) * Managed Instance commands updated with new property * Added enum defs for input parameter and updated Sql Server arg * fix blank line style error * Add minimal_tls_version for sql db server * adding tests * Adding recordings for tests * Re-record mi db test * Bump dependency version on azure-mgmt-sql, fix lint errors * Fix code style/lint errors * re-recorded tests * record tets * reset some of the test fixes and added recordings * reset some of the test fixes and added recordings * retry * style Co-authored-by: ziwa-msft <ziwa@microsoft.com> * [AppConfig] Unblock using appconfig kv set to add keyvault reference and feature flag (Azure#12377) * {Release} Upgrade to Azure CLI 2.2.0 (Azure#12486) * {Document} Fix dead documentation link to Microsoft open source page (Azure#12481) * {Compute} Delay vm image accept-terms expiration (Azure#12487) * {Packaging} Use python3 abspath in az script. (Azure#12467) * add test and fix 12387 (Azure#12518) * {CDN} Delay importing ErrorResponseException (Azure#12535) Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Co-authored-by: Shuai Wang <shuawan@microsoft.com> Co-authored-by: Jianhui Harold <haroldrandom@gmail.com> Co-authored-by: Xiaojian Xu <arrownj@126.com> Co-authored-by: Feiyue Yu <fey@microsoft.com> Co-authored-by: Bin Ma <bim@microsoft.com> Co-authored-by: Gao Ruifeng <gaoruifeng@users.noreply.github.com> Co-authored-by: Graham Zuber <grzuber@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Viacheslav Vasilyev <avoidik@gmail.com> Co-authored-by: Mads Damgård <madsd@microsoft.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> Co-authored-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com> Co-authored-by: Sambit Rath <es15btech11015@iith.ac.in> Co-authored-by: Azure CLI Bot <azclibot@microsoft.com> Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> Co-authored-by: Jiashuo Li <jiasli@microsoft.com> Co-authored-by: Liming Liu <andyliuliming@outlook.com> Co-authored-by: Jun Sun <33297523+JunSun17@users.noreply.github.com> Co-authored-by: stan-sz <37585349+stan-sz@users.noreply.github.com> Co-authored-by: Sylvain Rabot <sylvain@abstraction.fr> Co-authored-by: qianwens <37290631+qianwens@users.noreply.github.com> Co-authored-by: Sisira Panchagnula <panchagnula@users.noreply.github.com> Co-authored-by: Luca Boccassi <luca.boccassi@gmail.com> Co-authored-by: Yunge Zhu <37337818+yungezz@users.noreply.github.com> Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com> Co-authored-by: rashmichandrashekar <rashmy@microsoft.com> Co-authored-by: Chris Eggert <pilor@users.noreply.github.com> Co-authored-by: rakeshvanga <33327237+rakeshvanga@users.noreply.github.com> Co-authored-by: Qingqing <qizhe@microsoft.com> Co-authored-by: Matthew Booe <mirdaki@users.noreply.github.com> Co-authored-by: Brandon H <brandonh-msft@users.noreply.github.com> Co-authored-by: Tiano2017 <31759375+Tiano2017@users.noreply.github.com> Co-authored-by: Pengfei Ni <feiskyer@users.noreply.github.com> Co-authored-by: djnisic <djnisic@microsoft.com> Co-authored-by: Xiaofang Zhang <xizha@microsoft.com> Co-authored-by: Yugang Wang <yugangw@microsoft.com> Co-authored-by: yonzhan <54048360+yonzhan@users.noreply.github.com> Co-authored-by: Xiaojian Xu <xiaojxu@microsoft.com> Co-authored-by: Ramkumar Chandrasekaran <ramnov@users.noreply.github.com> Co-authored-by: emgu-ms <32528205+emgu-ms@users.noreply.github.com> Co-authored-by: Andrija Cicovic <60783126+cicovica@users.noreply.github.com> Co-authored-by: ziwa-msft <ziwa@microsoft.com> Co-authored-by: Jacob Bundgaard <jacob@jacobbundgaard.dk> Co-authored-by: Matthew Ryan <mjr@centauri.org> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

…data protection volumes and added replication operations (#12173) * ANF-448 additions for 2019-10-01 API * ANF-448 additions for 2019-10-01 API * update azure-mgmt-network to correct value * Fix versions * linter and style fixes * Updated list mount targest recording * updated test recordings * recodings python update * [netappfiles] Anf 448 cli for 2019 10 01 sync upstream (#6) * {Misc.} Update CODEOWNERS (#12149) * {Packaging} Update version management policy (#12095) * [AppConfig]Add customer managed key when updating stores. (#12102) * {Network} Connection Monitor V2 feature (#12140) * [Compute] BREAKING CHANGE: Fix #10728: `az vm create`: create subnet automatically if vnet is specified and subnet not exists (#12115) * [Compute] Fix #10728: `az vm create`: create subnet automatically if vnet is specified and subnet not exists * {Compute} update test_vm_commands to fix merge conflict * {Compute} fix test recording file for profile hybrid_2018_03_01 & hybrid_2019_03_01 * {Compute} update subnet help message & fail to create error message * {Compute} update fail to create subnet error message * {Compute} update test recording due to merge conflict * [Aladdin] Parse generated examples into commands' _help.py (#11716) * [Compute] Increase robustness of vm image list (#12134) * {KeyVault} Modify command group name `private-endpoint` to `private-endpoint-connection` (#12151) * {Compute} Add missing parameter to attach disk example command (#12045) attaching unmanaged disk without --name will cause error fix the example by adding `--name MyDataDisk` * [AppService] Add support for v3 function apps and node 12. (#11987) * [functionapp] Add support for v3 function apps and node 12. * Changed --version to --functions-version to help clarify version flags. Added functions version to invalid runtime version error. * Fixed styling. * [AppService] az webapp list-runtimes: Fix the bug for list-runtimes (#12172) * fix positional argument * add test for test_webapp_runtimes * {Packaging} Get rid of psutil dependency (#11665) * {Release} Auto generate history notes (#12098) * [AppService] az webapp|functionapp config ssl create: Add new commands to support create certificate (#11955) * Support for Managed Certificate * Adding slot support * Added unit test * History change * Remove history - part of PR description now * Block calls for Free and Shared tier * Update unit test * Rename command to create * Fix to error text * {Packaging} Remove Python 2 in setup and doc (#12155) * {Core} use caseless matching for provisioning_state (#12154) * Fix az group deployment create has an error when using large parameters.json file (#12047) * [ACR] `az acr login`: Throw a CLIError if there are errors returned by docker command (#12156) * [Backup] Fix for item level recovery flow in OLR (#12118) * Fix for item level recovery flow in OLR * style fix * [Backup] az backup recoveryconfig show: Add more parameters to support restoring as files for SQL/SAP Hana (#12116) * initial commit * updated tests * updated history.rst * cli style fix * {Release} Upgrade to Azure CLI 2.1.0 (#12195) * update azure-cli version to 2.1.0 * Update HISTORY.rst * {Package} remove requirements.py of python2 * Update commands.py Co-authored-by: Xiaojian Xu <arrownj@126.com> * [ARM] az resource: Improve the examples of the resource module (#11981) * {CI} Remove files related to Travis only (#12203) * {Monitor} az monitor autoscale create: add example for custom rule based on guest os. (#12205) * {azdev} Remove urllib3==1.24.2 from requirements.txt (#12211) * [AKS] fix the aks browse in cloud shell. (#12174) * {Storage} az storage share-rm: Add process_resource_group for resource group (#12232) * add validator=process_resource_group * refine storage account validator * add more validate * [AKS] az aks: Fix monitoring addon and agentpool NoneType errors. (#12250) * {SignalR} Fix show command fails with unexpected error when the resource doesn't exist (#12266) * Do not copy tests dirs in docker image (#12208) * [Storage] az storage blob delete-batch: Misbehaving `--dryrun` flag (#12162) * [Storage] az storage blob delete-batch: Misbehaving `--dryrun` flag * [Storage] az storage blob delete-batch: Misbehaving `--dryrun` flag * [ACR] Fix: `az acr login` wrongly raise error (#12282) * [Network] az network application-gateway rewrite-rule create: support url configuration (#12277) * [Network] az network dns zone import: --zone-name will be case insensitive in the future. (#12264) * fix (#12300) * [AppService] Fix #2258: Fixing issue where trying to create a webapp with certain runtimes was failing (#12260) * Fixing issue where trying to create a webapp with certain runtimes was failing updating history Upating to make sure NODE works as well when trying to set app_Settings Pylint fixes * Adding test & re-recording * Removing the formatting changes to keep the changes to just the bug fix * {Network} Supplemnt help message of --source-address-prefixes and --destination-address-prefixes for nsg rule creation (#12321) * {doc} Add Import Directive from docutils.parsers.rst for old API deprecation (#12295) sphinx.util.compat is deprecated since 1.6 and removed in 1.7. * {Document} update install troubleshooting (#12230) * {Network} Fix wrong import ZoneType of DNS (#12322) * update codeowners (#12201) * {Storage} Change api version range for storage account kind (#12265) * change min_api * change test * [CosmosDB] Add Sql stored procedure, udf and trigger cmdlets (#11999) * Added cosmosDB sql stored procedure, udf and trigger cmdlets * added help, fixed indentation, fixed wrong code * fixed a typo * indentation fix * flake8 issues fixed * PR comments * changed help accordingly * style fix * change in help msg * [ACS] (BREAKING CHANGE:) (az aks:) support msi changes for GF and BF for omsagent (Container monitoring)(#1) (#12100) * [ARM] az policy assignment list: Support listing policy assignments at Management Group scope (#12086) * Support listing policy assignments at MG scope * Fix test recording * Fix bug and add test case * {Packaging/Ubuntu} remove cosmic packaging (#12330) * {Container monitoring} - Add case insensitive string compare for msi string (#12341) * [KeyVault] keyvault create: enable soft-delete by default (#12204) * make PE and PLS GA (#12326) * [Network]az network bastion: support bastion (#12331) * [AKS] az aks use-dev-spaces: Adding endpoint type option to use-dev-spaces command to customize the endpoint created on a controller (#12028) * [AKS] add tag for nodepool (#12145) * {Packaging/Homebrew} Remove patch when upgrade (#12344) * {Find} az find: Remove EUII (#12349) * delete azure-cli-extension (#12362) * [Compute] sig image-version: add --data-snapshot-luns (#12303) * [AppService] functionapp: Added error message to deployment command if resource group/function name invalid (#12318) * [AppService] fixing flag cited in warning message (#12364) * [ARM] Refactor deployment commands (#10751) * update SDK version. * Refactor az deployment commands. * record tests. * test recordings. * [ACR] Add new command `az acr helm install-cli` (#12336) * [Network] az network vnet list-available-ips: support list available ips in a vnet (#12371) * Validate ip-address parameter + tests (#12312) * [AppService] functionapp: Updated container image configuration for Linux apps (#12317) * Updated linuxFxVersion configuration for linux apps. * Fixed HISTORY.rst, improved error message for invalid runtimes. * Changed how linuxFxVersion is handled for dotnet. Renamed constants for increased clarity. * [Network] Add new commands to manage flow-log and deprecate old configure command (#12350) * {Packaging/windows pip} Use local python for az.bat (#12323) * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent (#12327) * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [Storage] az storage account network-rule add (bug fix): add operation should be idempotent * [AKS] Add support of creating private cluster (#12353) * [SQL] Sql midb Add: list-deleted, show-deleted, update-retention, show-retention (#12033) * Adding support for short term retention and deleted database for MI * Fixing help file * Fixing help file * Updating tests * Adressing comments * Fixing style errors * Fixing help files * Fixing help files * Resyncing required for tests * Chaning deletion-time to deleted-time * More details in description on retention_days * Adressing comments * {KeyVault} Fix the case sensitive issue while running commands without specifying resource group name (#12405) * {Storage} az storage file copy start: add examples for snapshot #12410 * {Documentation}Command guideline for private endpoint connection and private link resource (#12403) * [AKS] add support for creation time node labels (#12418) * move propagate_env_change.exe to storage account (#12401) * {Telemetry} Disable telemetry for some clouds (#12400) * [Storage] az storage account create/update: Add Routing Preference support (#12309) * add routing preferences * add test * fix style and rerun test * add tests and refine code * Add test for false * {Monitor}show command should return 3 (#12404) * {Find} Suppress old find extension (#12432) * [Storage] Upgrade azure-mgmt-storage version to 8.0.0 (#12437) * [ACR]: private link and CMK support (#12381) * [AppService] Fix #12251 app settings race condition during zip deploy (#12262) * Acr: remove private .wheel file (#12450) * [RDBMS] Support Private Endpoint Connections (#12394) * [Compute] ppg show: add --colocation-status to Enable fetching the colocation status of all the resources in the proximity placement group (#12248) * [Compute] vm/vmss/availability-set update: add --ppg to allowing updating ProximityPlacementGroup * stage * add test * Add help; Support translataion from name to ID * [Compute] ppg show: add --colocation to Enable fetching the colocation status of all the resources in the proximity placement group * Add test * update parameter name * test * revolve some comments * Update parameter * compute 11.0.0 * test * fix test * fix * {Compute} fix none check when list vmss extension. (#11914) * [AKS] add missing / in the dashboard url. (#12411) * add allowProtectedAppendWrite (#12448) * [Monitor] az monitor metrics alert create: support `~` in `--condition`. (#12439) * update codeowners (#12453) * Improve the help of az policy assignment create (#12343) * Fix the bug that automatically generated name of policy assignment exceeds the limit (#12352) * [Cosmos DB] az cosmosdb create: add --key-uri to support adding key vault encryption information (#12417) * adding key-value-key-uri to cosmos db * remove history note * update package in requirements * remove whitespace on blank line * remove whitespace from blank line * add preview flag and update test * re-running tests with new API version * rename new parameter * [ARM] az group deployment create: Add parameter `--aux-tenants` to support cross tenants (#11765) (#12221) * Add parameter --aux-tenants to support cross tenants for az group deployment create * Add cross tenant support to the refactored deployment group create * [ACR] add 'private-link-resource list' command (#12454) * {Documentation}fix documenttation (#12435) * [AKS] Support create aks clusters enabling managed identity (#12420) * Support create aks clusters enabling managed identity * Remove 'preview' * Add test case for AKS using managed identity * [CDN] Add CDN WAF commands (#12071) * [Core] az cloud show: add insights telemetry channel endpoint for China/US cloud (#12442) * [Storage] Add support for private link resource (#12383) * initialize privete link for storage * refine command with help * refine help * pass test_storage_account_private_link * add exception handler * add exception handler * pass test * fix style * change list-private-link-resource to private-link-resource list * fix style and linter * apply validator and transform in core * enabled id_part for private linke resource list * remove previous validator and transform in storage * fix style * pass test * add ids for private link resource list * resolve comments * remove --ids to make linter pass * [Compute] az vmss create/update: support automatic repairs (#12374) * [Compute] az vmss create/update: support automatic repairs * {Compute} fix automatic repairs style error * {Compute} update help message for --automatic-repairs-grace-period * {Compute} update validator error message for automatic repairs * {Compute} add automatic repairs arg group in vmss update * {Compute} fix sytle error in _params.py * [AKS] Validate network plugin to be either "azure" or "kubenet". (#12376) * [AppService] Fix #5720946: az webapp backup fails to set name (#11929) * Fix backup name set functionality * Add test for backup * changes to meet checkstyles * add recording * [RBAC] az ad group show: fix --group value treated as regex problem (#12426) * [RBAC] az ad group show: fix --group value treated as regex problem * {RBAC} update syntax error of error message * {RBAC} retrieve domain from az ad signed-in-user show instead of hard code * {RBAC} refactor validate_group function * {RBAC} update recording file for test_graph_group_idempotent * {RBAC} update test_graph * {RBAC} update test_graph to use the right user info Co-authored-by: Xiaojian Xu <xiaojxu@microsoft.com> * [Storage] Add PITR support (#12372) * add action for blob range * add -t for time_to_restore * add restore_policy properties * rename restore_retention_days to restore_days * try to add test * add support_no_wait * refine test * fix style * enable no wait for restore * pass live test * fix comments and make blob range opetional * fix style * {KeyVault} Modify private link commands to align with storage (#12457) * {Core} Change help example hook (#12431) * [AKS] Add aad session key support. (#12290) * {Release} use pat for github requests (#12474) * {Packaging} bump up pyyaml (#12440) * [RDBMS] Updating RDBMS Private Endpoint Tests (#12475) * [Compute] image builder create: add --image-template\n[Compute] [BREAKING CHANGE] image template: rename template to builder (#11865) * Add test for latest profile * [Compute] image template create: add --customize and --distribute * Add history * Fix style * Update test * rename template to builder * update help * add image_template * --image-template * test * remove --customize and --distribute * try-catch json error * help * fix style * fix a bug; update help * test of local file * Add example * error handle * help * [SQL] az sql server create/update: Add --enable-public-network to support PublicNetworkAccess (#12382) * Add PublicNetworkAccess to Create and Update Server * Fix some styling + rerecorded tests * Fix more CLI style * Cleaned up code according to comments * Change public-network-access to enable-public-network * Bump up azure-mgmt-sql version * Rerecorded a couple of failing tests * Rerecord a couple more tests * Forgot to update test_sql_commands * Rerecord another test * Updating more tests * Small changes + more rerecorded tests * Fix style check errors * Random small change to rerun tests * Replace API versions * Fix style * [SQL DB, SQL MI] Add minimal_tls_version property for MI and SQL DB (#12414) * Managed Instance commands updated with new property * Added enum defs for input parameter and updated Sql Server arg * fix blank line style error * Add minimal_tls_version for sql db server * adding tests * Adding recordings for tests * Re-record mi db test * Bump dependency version on azure-mgmt-sql, fix lint errors * Fix code style/lint errors * re-recorded tests * record tets * reset some of the test fixes and added recordings * reset some of the test fixes and added recordings * retry * style Co-authored-by: ziwa-msft <ziwa@microsoft.com> * [AppConfig] Unblock using appconfig kv set to add keyvault reference and feature flag (#12377) * {Release} Upgrade to Azure CLI 2.2.0 (#12486) * {Document} Fix dead documentation link to Microsoft open source page (#12481) * {Compute} Delay vm image accept-terms expiration (#12487) * {Packaging} Use python3 abspath in az script. (#12467) * add test and fix 12387 (#12518) * {CDN} Delay importing ErrorResponseException (#12535) Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Co-authored-by: Shuai Wang <shuawan@microsoft.com> Co-authored-by: Jianhui Harold <haroldrandom@gmail.com> Co-authored-by: Xiaojian Xu <arrownj@126.com> Co-authored-by: Feiyue Yu <fey@microsoft.com> Co-authored-by: Bin Ma <bim@microsoft.com> Co-authored-by: Gao Ruifeng <gaoruifeng@users.noreply.github.com> Co-authored-by: Graham Zuber <grzuber@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Viacheslav Vasilyev <avoidik@gmail.com> Co-authored-by: Mads Damgård <madsd@microsoft.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> Co-authored-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com> Co-authored-by: Sambit Rath <es15btech11015@iith.ac.in> Co-authored-by: Azure CLI Bot <azclibot@microsoft.com> Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> Co-authored-by: Jiashuo Li <jiasli@microsoft.com> Co-authored-by: Liming Liu <andyliuliming@outlook.com> Co-authored-by: Jun Sun <33297523+JunSun17@users.noreply.github.com> Co-authored-by: stan-sz <37585349+stan-sz@users.noreply.github.com> Co-authored-by: Sylvain Rabot <sylvain@abstraction.fr> Co-authored-by: qianwens <37290631+qianwens@users.noreply.github.com> Co-authored-by: Sisira Panchagnula <panchagnula@users.noreply.github.com> Co-authored-by: Luca Boccassi <luca.boccassi@gmail.com> Co-authored-by: Yunge Zhu <37337818+yungezz@users.noreply.github.com> Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com> Co-authored-by: rashmichandrashekar <rashmy@microsoft.com> Co-authored-by: Chris Eggert <pilor@users.noreply.github.com> Co-authored-by: rakeshvanga <33327237+rakeshvanga@users.noreply.github.com> Co-authored-by: Qingqing <qizhe@microsoft.com> Co-authored-by: Matthew Booe <mirdaki@users.noreply.github.com> Co-authored-by: Brandon H <brandonh-msft@users.noreply.github.com> Co-authored-by: Tiano2017 <31759375+Tiano2017@users.noreply.github.com> Co-authored-by: Pengfei Ni <feiskyer@users.noreply.github.com> Co-authored-by: djnisic <djnisic@microsoft.com> Co-authored-by: Xiaofang Zhang <xizha@microsoft.com> Co-authored-by: Yugang Wang <yugangw@microsoft.com> Co-authored-by: yonzhan <54048360+yonzhan@users.noreply.github.com> Co-authored-by: Xiaojian Xu <xiaojxu@microsoft.com> Co-authored-by: Ramkumar Chandrasekaran <ramnov@users.noreply.github.com> Co-authored-by: emgu-ms <32528205+emgu-ms@users.noreply.github.com> Co-authored-by: Andrija Cicovic <60783126+cicovica@users.noreply.github.com> Co-authored-by: ziwa-msft <ziwa@microsoft.com> Co-authored-by: Jacob Bundgaard <jacob@jacobbundgaard.dk> Co-authored-by: Matthew Ryan <mjr@centauri.org> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> * Changing the Replication command pause to suspend. * Updated help texts Co-authored-by: leonard <leonard.francis@netapp.com> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Co-authored-by: Shuai Wang <shuawan@microsoft.com> Co-authored-by: Jianhui Harold <haroldrandom@gmail.com> Co-authored-by: Xiaojian Xu <arrownj@126.com> Co-authored-by: Feiyue Yu <fey@microsoft.com> Co-authored-by: Bin Ma <bim@microsoft.com> Co-authored-by: Gao Ruifeng <gaoruifeng@users.noreply.github.com> Co-authored-by: Graham Zuber <grzuber@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: Viacheslav Vasilyev <avoidik@gmail.com> Co-authored-by: Mads Damgård <madsd@microsoft.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> Co-authored-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com> Co-authored-by: Sambit Rath <es15btech11015@iith.ac.in> Co-authored-by: Azure CLI Bot <azclibot@microsoft.com> Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> Co-authored-by: Jiashuo Li <jiasli@microsoft.com> Co-authored-by: Liming Liu <andyliuliming@outlook.com> Co-authored-by: Jun Sun <33297523+JunSun17@users.noreply.github.com> Co-authored-by: stan-sz <37585349+stan-sz@users.noreply.github.com> Co-authored-by: Sylvain Rabot <sylvain@abstraction.fr> Co-authored-by: qianwens <37290631+qianwens@users.noreply.github.com> Co-authored-by: Sisira Panchagnula <panchagnula@users.noreply.github.com> Co-authored-by: Luca Boccassi <luca.boccassi@gmail.com> Co-authored-by: Yunge Zhu <37337818+yungezz@users.noreply.github.com> Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com> Co-authored-by: rashmichandrashekar <rashmy@microsoft.com> Co-authored-by: Chris Eggert <pilor@users.noreply.github.com> Co-authored-by: rakeshvanga <33327237+rakeshvanga@users.noreply.github.com> Co-authored-by: Qingqing <qizhe@microsoft.com> Co-authored-by: Matthew Booe <mirdaki@users.noreply.github.com> Co-authored-by: Brandon H <brandonh-msft@users.noreply.github.com> Co-authored-by: Tiano2017 <31759375+Tiano2017@users.noreply.github.com> Co-authored-by: Pengfei Ni <feiskyer@users.noreply.github.com> Co-authored-by: djnisic <djnisic@microsoft.com> Co-authored-by: Xiaofang Zhang <xizha@microsoft.com> Co-authored-by: Yugang Wang <yugangw@microsoft.com> Co-authored-by: yonzhan <54048360+yonzhan@users.noreply.github.com> Co-authored-by: Xiaojian Xu <xiaojxu@microsoft.com> Co-authored-by: Ramkumar Chandrasekaran <ramnov@users.noreply.github.com> Co-authored-by: emgu-ms <32528205+emgu-ms@users.noreply.github.com> Co-authored-by: Andrija Cicovic <60783126+cicovica@users.noreply.github.com> Co-authored-by: ziwa-msft <ziwa@microsoft.com> Co-authored-by: Jacob Bundgaard <jacob@jacobbundgaard.dk> Co-authored-by: Matthew Ryan <mjr@centauri.org>

rakeshvanga added 2 commits February 3, 2020 17:38

adding endpoint type option for dev spaces command

1f1fe87

revert the changes for launh.json file

e8c122f

yonzhan assigned qwordy Feb 4, 2020

yonzhan requested review from mmyyrroonn, qwordy and yugangw-msft February 4, 2020 01:52

yonzhan added this to the S165 milestone Feb 4, 2020

amsoedal reviewed Feb 4, 2020

View reviewed changes

src/azure-cli/azure/cli/command_modules/acs/custom.py Outdated Show resolved Hide resolved

fixed linter errors/warnings

b233df3

rakeshvanga changed the title ~~[AKS] Use_dev_spaces: Adding endpoint type option~~ [ACS] az aks use-dev-spaces: Adding endpoint type option to use-dev-spaces command to customize the endpoint created on a controller Feb 4, 2020

Using inplace list for endpointType

029b32e

amsoedal approved these changes Feb 12, 2020

View reviewed changes

yonzhan modified the milestones: S165, S166 Feb 15, 2020

qwordy approved these changes Feb 16, 2020

View reviewed changes

Merge branch 'dev' of https://github.com/Azure/azure-cli into dev

d5e28a1

qwordy merged commit e5a1c43 into Azure:dev Feb 25, 2020

Conversation

rakeshvanga commented Feb 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

History Notes: [ACS] az aks use-dev-spaces: Adding endpoint type option to the use-dev-spaces command to customize the endpoint created on an Azure Dev Spaces controller.

Uh oh!

yonzhan commented Feb 4, 2020

Uh oh!

Uh oh!

amsoedal left a comment

Choose a reason for hiding this comment

Uh oh!

sanar-microsoft commented Feb 20, 2020

Uh oh!

azure-pipelines bot commented Feb 20, 2020

Uh oh!

sanar-microsoft commented Feb 20, 2020

Uh oh!

rakeshvanga commented Feb 20, 2020

Uh oh!

azure-pipelines bot commented Feb 20, 2020

Uh oh!

rakeshvanga commented Feb 21, 2020

Uh oh!

qwordy commented Feb 21, 2020

Uh oh!

azure-pipelines bot commented Feb 21, 2020

Uh oh!

rakeshvanga commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qwordy commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haroldrandom commented Feb 24, 2020

Uh oh!

azure-pipelines bot commented Feb 24, 2020

Uh oh!

haroldrandom commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qwordy commented Feb 24, 2020

Uh oh!

rakeshvanga commented Feb 25, 2020

Uh oh!

haroldrandom commented Feb 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rakeshvanga commented Feb 4, 2020 •

edited

Loading

History Notes:
[ACS] az aks use-dev-spaces: Adding endpoint type option to the use-dev-spaces command to customize the endpoint created on an Azure Dev Spaces controller.

rakeshvanga commented Feb 21, 2020 •

edited

Loading

qwordy commented Feb 24, 2020 •

edited

Loading

haroldrandom commented Feb 24, 2020 •

edited

Loading