[DO NOT MERGE] ACR: private link and CMK support#12348
[DO NOT MERGE] ACR: private link and CMK support#12348yugangw-msft wants to merge 11 commits intoAzure:devfrom
Conversation
yugangw-msft
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom,
jiasli and
qianwens
as code owners
There was a problem hiding this comment.
Should we have a command called az acr private-link-resource to show all available private link resources? "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/privateLinkResources": {
| with self.command_group('acr token credential', acr_token_credential_generate_util) as g: | ||
| g.command('generate', 'acr_token_credential_generate') | ||
|
|
||
| with self.command_group('acr private-endpoint-connection', acr_private_endpoint_connection_util, |
There was a problem hiding this comment.
we're using command to reflect custom command. I'm fine 😄 @Juliehzl
There was a problem hiding this comment.
Hey @myronfanqiu, I am not sure what you meant here. Please can you review / comment on #12381
| WORKDIR azure-cli | ||
| COPY . /azure-cli | ||
|
|
||
| RUN pip install ./privates/azure_mgmt_containerregistry-3.0.0rc8-py2.py3-none-any.whl |
There was a problem hiding this comment.
well. Looks like it's just a private package.
There was a problem hiding this comment.
@adewaleo, make sure revert it before merge. We must publish the SDK package beforehand
| 'provider_operations_metadata': '2018-01-01-preview' | ||
| }), | ||
| ResourceType.MGMT_CONTAINERREGISTRY: '2019-06-01-preview', | ||
| ResourceType.MGMT_CONTAINERREGISTRY: SDKProfile('2019-12-01-preview', { |
There was a problem hiding this comment.
well. I cannot find such api-version in https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/containerregistry/azure-mgmt-containerregistry/azure/mgmt/containerregistry.
There was a problem hiding this comment.
The SDK publishing is pending.
I have marked this PR as "Do not merge" to prevent any incidental merge
yugangw-msft
changed the title
|
PR to finish this here: #12381 |
5 participants
On private link we use the Keyvault's pattern which is
az acr private-endpoint-connection approve/delete/reject/show/listOn CMK, we use the VM's pattern
az acr encryptionThis PR is pending SDK release for azure-mgmt-containerregistry
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.