{Aladdin} add usage examples for module: monitor network privatedns resource storage vm #12499
Merged
haroldrandom merged 21 commits intoAzure:devfrom Apr 20, 2020
Merged
Conversation
azclibot
requested review from
Juliehzl,
arrownj,
haroldrandom,
mmyyrroonn,
qianwens,
qwordy and
zhoxing-ms
as code owners
haroldrandom
reviewed
Mar 7, 2020
| - name: Update an application gateway WAF policy. (autogenerated) | ||
| text: | | ||
| az network application-gateway waf-policy update --name MyApplicationGatewayWAFPolicy --remove tags.no_80 --resource-group MyResourceGroup | ||
| crafted: true |
Contributor
There was a problem hiding this comment.
Aladdin observed that usage pattern changed over time. So delete this.
haroldrandom
reviewed
Mar 7, 2020
| - name: Update an outbound-rule. (autogenerated) | ||
| text: | | ||
| az network lb outbound-rule update --frontend-ip-configs myfrontendoutbound --lb-name MyLb --name MyOutboundRule --resource-group MyResourceGroup | ||
| crafted: true |
Contributor
There was a problem hiding this comment.
Aladdin observed that usage pattern changed over time. So delete this
haroldrandom
reviewed
Mar 7, 2020
Collaborator
|
add to S167. |
Juliehzl
reviewed
Mar 9, 2020
Juliehzl
reviewed
Mar 9, 2020
Juliehzl
reviewed
Mar 9, 2020
mmyyrroonn
reviewed
Mar 9, 2020
Contributor
mmyyrroonn
left a comment
mmyyrroonn
left a comment
There was a problem hiding this comment.
Well. It's still hard for me to review this PR. For network, we have too much commands and usually we need to test it before we write down an example. @haroldrandom Do you know the source of these examples? Does it come from real telemetry or our example?
Aladdin didn't learn from last time.
Co-Authored-By: Feiyue Yu <fey@microsoft.com>
qwordy
reviewed
Apr 2, 2020
qwordy
approved these changes
Apr 3, 2020
jiasli
approved these changes
Apr 7, 2020
qwordy
approved these changes
Apr 8, 2020
fengzhou-msft
approved these changes
Apr 13, 2020
haroldrandom
approved these changes
Apr 15, 2020
zhoxing-ms
reviewed
Apr 16, 2020
Comment on lines
1777
to
+1782
| - name: Create an empty MX record set. | ||
| text: az network dns record-set mx create -g MyResourceGroup -z www.mysite.com -n MyRecordSet | ||
| - name: Create an empty MX record set. (autogenerated) | ||
| text: | | ||
| az network dns record-set mx create --name MyRecordSet --resource-group MyResourceGroup --ttl 30 --zone-name www.mysite.com | ||
| crafted: true |
Contributor
There was a problem hiding this comment.
The commands in the autogenerated document has a few more parameters. Could the name describe these parameters more, so as to be different from the above name.
zhoxing-ms
approved these changes
Apr 16, 2020
mmyyrroonn
approved these changes
Apr 17, 2020
Juliehzl
reviewed
Apr 17, 2020
| - name: Update the storage blob delete-policy. (autogenerated) | ||
| text: | | ||
| az storage blob service-properties delete-policy update --account-name mystorageccount --account-key 00000000 --days-retained 7 --enable true | ||
| az storage blob service-properties delete-policy update --account-name mystorageccount --days-retained 7 --enable true |
Juliehzl
reviewed
Apr 17, 2020
Juliehzl
approved these changes
Apr 17, 2020
qwordy
reviewed
Apr 20, 2020
Co-Authored-By: Feiyue Yu <fey@microsoft.com>
azure-sdk
added
the
customer-reported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created by AladdinParser Pipeline which is automatically triggered by a merge of Aladdin-src branch: #11873.
ADO_BUILD_ID=283190
Against last commit of dev: 1174a3350
Against last commit of Aladdin-src: d77da4f