{Core} Only lower provisioning_state when it has value#12532
Merged
{Core} Only lower provisioning_state when it has value#12532
Conversation
fengzhou-msft
approved these changes
Mar 11, 2020
haroldrandom
approved these changes
Mar 11, 2020
Contributor
|
My concern is that although your current change will not break users ay more, the sql wait command still doesn't work now. |
Member
Author
I have put my thought in #12313 (comment). But anyway, let's fix the regression first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the regression in #12154:
provisioning_state.casefold()raises exceptionAttributeError: 'NoneType' object has no attribute 'casefold'whenprovisioning_stateisNone.This causes issue to
az sql server waitsince sql server doesn't use"provisioningState": "Succeeded", but"state": "Ready": #12313Only lower
provisioning_statewhen it has value (notNoneor empty string'').Tested with
Also, use
lower()to be consistent with other code.