Conversation
Collaborator
|
add to S167 |
arrownj
reviewed
Mar 23, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
pixia
reviewed
Mar 23, 2020
pixia
reviewed
Mar 23, 2020
pixia
reviewed
Mar 24, 2020
pixia
reviewed
Mar 24, 2020
pixia
reviewed
Mar 24, 2020
Contributor
|
I would love if the length of |
jaredmoo
reviewed
Apr 9, 2020
jaredmoo
reviewed
Apr 9, 2020
jaredmoo
approved these changes
Apr 10, 2020
Juliehzl
reviewed
Apr 14, 2020
Juliehzl
reviewed
Apr 14, 2020
Juliehzl
requested changes
Apr 14, 2020
Contributor
Juliehzl
left a comment
There was a problem hiding this comment.
Please add checks for all your test commands to make sure commands output is as expected.
Juliehzl
reviewed
Apr 15, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
Juliehzl
reviewed
Apr 15, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Apr 15, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
Juliehzl
reviewed
Apr 16, 2020
Juliehzl
reviewed
Apr 16, 2020
Juliehzl
reviewed
Apr 16, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
Juliehzl
reviewed
Apr 16, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Apr 16, 2020
…dded is_preview=True to new commands; added ability to use int arguments to configure retention settings in days
Juliehzl
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.