[CosmosDB]Support az cosmosdb private-link-resource and private-endpoint-connection#12960
Merged
mmyyrroonn merged 10 commits intoAzure:devfrom Apr 17, 2020
Merged
[CosmosDB]Support az cosmosdb private-link-resource and private-endpoint-connection#12960mmyyrroonn merged 10 commits intoAzure:devfrom
mmyyrroonn merged 10 commits intoAzure:devfrom
Conversation
soeom
changed the title
Collaborator
|
add to S168 |
Contributor
Author
|
@jsntcy @qianwens @myronfanqiu @Juliehzl Can you review this PR? |
Juliehzl
reviewed
Apr 15, 2020
Juliehzl
reviewed
Apr 15, 2020
Juliehzl
reviewed
Apr 15, 2020
mmyyrroonn
reviewed
Apr 15, 2020
src/azure-cli/azure/cli/command_modules/cosmosdb/_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/cosmosdb/tests/latest/test_cosmosdb_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/cosmosdb/tests/latest/test_cosmosdb_commands.py
Show resolved
Hide resolved
Juliehzl
reviewed
Apr 15, 2020
Contributor
Author
|
@myronfanqiu @Juliehzl I fixed following all comments and command guideline. Please take a look at PR again. |
mmyyrroonn
reviewed
Apr 16, 2020
Juliehzl
approved these changes
Apr 16, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
LGTM. But please make CI pass.
Contributor
Author
|
Please help merge the PR @myronfanqiu |
mmyyrroonn
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.