[ARO] az aro: Fix table output#13066
Conversation
|
add to S169 |
ebf96ff to
edf4d37
Compare
|
Could you please add __init__.py under And adding this require re-recording tests. |
edf4d37 to
e0fa70d
Compare
|
Good catch! Added |
One reason why CI failed is azure-mgmt-network has bumped to a newer version, you could re-recordin test to resolve this. |
e0fa70d to
6fc8b44
Compare
Fixes a bug in `az aro {command} --output table` (`az aro list --output table`, for example) when the comamnd fails due to not taking into account potential `None` values in data in some edge cases table output currently fails. For example:
* When there are no worker profiles (cluster only has masters or we failed to get data from API server)
* When a worker profile does not have count (machine set was scaled to 0)
6fc8b44 to
0ec9ffb
Compare
|
@jiasli @haroldrandom please take a look. I rebased on top of |
Description
Fixes a bug in
az aro {command} --output table(az aro list --output table, for example) when the comamnd fails due to not taking into account potentialNonevalues in data in some edge cases table output currently fails. For example:Testing Guide
Create an ARO cluster, scale all machine sets to 0 and try to run
az aro list --output table.History Notes
[ARO] az aro: Fix table output
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.