[AKS] az aks create: Add support for Windows#13084
Merged
Conversation
Member
|
HI @arrownj could you pls review? thanks |
Member
Author
|
Thanks for the help, @arrownj . Please do not merge this. I will update add-node-pool with setting default node vm size for windows but not raise an error. |
Member
Author
|
Updated src\azure-cli\azure\cli\command_modules\acs\custom.py and added `add/delete windows node pool' in test_aks_commands.py => |
Contributor
|
Hi @AbelHu , is this ready to merge ? Code looks good to me. |
Member
Author
|
@arrownj . It is ready now. Expect your help to merge it. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will allow cx to create a k8s cluster and then add Windows agent pools without aks-preview.
Testing Guide
AZURE_CLI_TEST_DEV_SP_NAME=1f3a7c5e-1812-4aa7-bffe-b5ef651cbab2 AZURE_CLI_TEST_DEV_SP_PASSWORD='6997d05f-3cae-4bcc-95f0-b74cf5444860' CAZURE_CLI_TEST_MODULES=acs azdev test test_aks_create_with_windows --discover --live
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
[x ] The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.