Skip to content

[Monitor] Support LA cluster CMK features#13133

Merged
yonzhan merged 8 commits intoAzure:devfrom
jsntcy:monitor-jedi-private-sdk
Apr 26, 2020
Merged

[Monitor] Support LA cluster CMK features#13133
yonzhan merged 8 commits intoAzure:devfrom
jsntcy:monitor-jedi-private-sdk

Conversation

@jsntcy
Copy link
Member

@jsntcy jsntcy commented Apr 23, 2020

Description
This PR implement the following features:

  • LA cluster CRUD
  • Link/unlink LA workspace with cluster

Testing Guide

History Notes

az monitor log-analytics cluster create/update/show/delete/list
az monitor log-analytics workspace linked-service create/update/show/delete/list


This checklist is used to make sure that common guidelines for a pull request are followed.

@jsntcy jsntcy requested a review from mmyyrroonn as a code owner April 23, 2020 08:42
@jsntcy jsntcy requested review from haroldrandom and yonzhan April 23, 2020 08:43
@jsntcy jsntcy self-assigned this Apr 23, 2020
Copy link
Contributor

@mmyyrroonn mmyyrroonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

with self.argument_context('monitor log-analytics workspace linked-service') as c:
c.argument('linked_service_name', name_arg_type, help='Name of the linkedServices resource. Supported values: cluster, automation.')
c.argument('workspace_name', options_list='--workspace-name')
c.argument('resource_id', help='The resource id of the resource that will be linked to the workspace. This '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which kinds of resources are acceptable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource type is defined by linked_service_name which support automation and cluster


In reply to: 413634067 [](ancestors = 413634067)

c.argument('sku_capacity', help='The capacity of the SKU. It must be in the range of 1000-2000 per day and must'
' be in multiples of 100. If you want to increase the limit, please contact'
' LAIngestionRate@microsoft.com. It can be decreased only after 31 days.')
c.argument('identity_type', help='The identity type. Supported values: SystemAssigned, None')
Copy link
Contributor

@mmyyrroonn mmyyrroonn Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the meaning of None? #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem not support 'None' and will confirm with service team


In reply to: 413634993 [](ancestors = 413634993)

# Make cluster creation no wait by default before ADX cluster can be provisioned automatically.
# TODO: remove this method and make cluster creation support both wait and no wait
# after ADX cluster can be provisioned automatically.
cmd.supports_no_wait = True
Copy link
Contributor

@mmyyrroonn mmyyrroonn Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this one? If user input --no-wait False, will it cause endless loop? #WontFix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we'll not expose --no-wait to users as I didn't add supports_no_wait=True in command definition.


In reply to: 413669222 [](ancestors = 413669222)

@yonzhan yonzhan added this to the S169 - For Build milestone Apr 23, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 23, 2020

add to S169

@jsntcy jsntcy changed the title Monitor jedi private sdk [Monitor] Support LA cluster CMK features Apr 23, 2020
@jsntcy jsntcy requested a review from fengzhou-msft as a code owner April 24, 2020 11:05
@yonzhan yonzhan merged commit f4ff610 into Azure:dev Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants