[Monitor] Support LA cluster CMK features#13133
Conversation
src/azure-cli/azure/cli/command_modules/monitor/_client_factory.py
Outdated
Show resolved
Hide resolved
| with self.argument_context('monitor log-analytics workspace linked-service') as c: | ||
| c.argument('linked_service_name', name_arg_type, help='Name of the linkedServices resource. Supported values: cluster, automation.') | ||
| c.argument('workspace_name', options_list='--workspace-name') | ||
| c.argument('resource_id', help='The resource id of the resource that will be linked to the workspace. This ' |
There was a problem hiding this comment.
which kinds of resources are acceptable?
There was a problem hiding this comment.
The resource type is defined by linked_service_name which support automation and cluster
In reply to: 413634067 [](ancestors = 413634067)
| c.argument('sku_capacity', help='The capacity of the SKU. It must be in the range of 1000-2000 per day and must' | ||
| ' be in multiples of 100. If you want to increase the limit, please contact' | ||
| ' LAIngestionRate@microsoft.com. It can be decreased only after 31 days.') | ||
| c.argument('identity_type', help='The identity type. Supported values: SystemAssigned, None') |
There was a problem hiding this comment.
what's the meaning of None? #Resolved
There was a problem hiding this comment.
Seem not support 'None' and will confirm with service team
In reply to: 413634993 [](ancestors = 413634993)
| # Make cluster creation no wait by default before ADX cluster can be provisioned automatically. | ||
| # TODO: remove this method and make cluster creation support both wait and no wait | ||
| # after ADX cluster can be provisioned automatically. | ||
| cmd.supports_no_wait = True |
There was a problem hiding this comment.
should we remove this one? If user input --no-wait False, will it cause endless loop? #WontFix
There was a problem hiding this comment.
No, we'll not expose --no-wait to users as I didn't add supports_no_wait=True in command definition.
In reply to: 413669222 [](ancestors = 413669222)
|
add to S169 |
Description
This PR implement the following features:
Testing Guide
History Notes
az monitor log-analytics cluster create/update/show/delete/listaz monitor log-analytics workspace linked-service create/update/show/delete/listThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.