[Monitor] az monitor log-analytics workspace linked-storage: supports BYOS features#13187
Merged
mmyyrroonn merged 5 commits intoAzure:devfrom Apr 27, 2020
Merged
[Monitor] az monitor log-analytics workspace linked-storage: supports BYOS features#13187mmyyrroonn merged 5 commits intoAzure:devfrom
mmyyrroonn merged 5 commits intoAzure:devfrom
Conversation
added 2 commits
April 26, 2020 16:51
recording finish tests
jsntcy
reviewed
Apr 26, 2020
| type: command | ||
| short-summary: Create linked storages for log analytics workspace. | ||
| examples: | ||
| - name: Create a linked storage for a log analytics workspace |
Member
There was a problem hiding this comment.
a [](start = 17, length = 1)
two
Contributor
Author
There was a problem hiding this comment.
I prefer using a instead of two. linked-storage-account is a resource which has several linked storage accounts. Two is quite strange.
jsntcy
reviewed
Apr 26, 2020
| linked_storage_accounts = client.get(resource_group_name=resource_group_name, | ||
| workspace_name=workspace_name, | ||
| data_source_type=data_source_type) | ||
| existed_storage_account_ids_set = set(linked_storage_accounts.storage_account_ids) |
Member
There was a problem hiding this comment.
How about write code as follows,
if storage_account_id.lower() in [existing_storage_acocunt_id.lower() for existing_storage_acocunt_id in linked_storage_accounts.storage_account_ids]:
linked_storage_accounts.storage_account_ids.remove(storage_account_id)
Contributor
Author
There was a problem hiding this comment.
each iteration we need a list generation, which is quite resource consuming. But I change the logic to generate set.
jsntcy
reviewed
Apr 26, 2020
|
|
||
| helps['monitor log-analytics workspace linked-storage create'] = """ | ||
| type: command | ||
| short-summary: Create linked storages for log analytics workspace. |
Member
There was a problem hiding this comment.
storage accounts. also update other places
Collaborator
|
add to S169 |
added 2 commits
April 27, 2020 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.