{Identity} Adopt latest changes from Azure Identity #10612#13473
Merged
jiasli merged 3 commits intoAzure:identityfrom May 13, 2020
Merged
{Identity} Adopt latest changes from Azure Identity #10612#13473jiasli merged 3 commits intoAzure:identityfrom
jiasli merged 3 commits intoAzure:identityfrom
Conversation
jiasli
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom and
qianwens
as code owners
jiasli
changed the title
jiasli
commented
May 13, 2020
| return InteractiveBrowserCredential(profile=auth_profile, silent_auth_only=True) | ||
| auth_record = AuthenticationRecord(self.tenant_id, self.client_id, self.authority, | ||
| home_account_id, username) | ||
| return InteractiveBrowserCredential(authentication_record=auth_record, disable_automatic_authentication=True, |
Member
Author
There was a problem hiding this comment.
InteractiveCredential/PublicClientCredential which is the base class of InteractiveBrowserCredential and DeviceCodeCredential should be exposed in azure/identity/__init__.py.
CLI won't know which type the user used to login before. Choosing any one of InteractiveBrowserCredential and DeviceCodeCredential works, yes, but this is not a good programming practice as we are using the base class from sub class. See Teams thread: InteractiveCredential should be exposed
# Conflicts: # src/azure-cli-core/azure/cli/core/_identity.py
jiasli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adopt latest changes from Azure Identity Azure/azure-sdk-for-python#10612
As stated in chlowell/azure-sdk-for-python#4 (comment),
UsernamePasswordCredentialdoesn't supportauthenticateanymore. When username+password is used as authentication method,AuthenticationRecordcan't be created. Azure CLI can't persistAuthenticationRecordand retrieve the refresh token anymore.Actually, I think maybe we shouldn't use the name Interactive, but instead, we can flatten
InteractiveCredentialand directly putInteractiveBrowserCredential,DeviceCodeCredentialandUsernamePasswordCredentialunderPublicClientCredential.Created Teams thread :UsernamePasswordCredential.authenticate is removed