Skip to content

[NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function#13481

Merged
haroldrandom merged 8 commits intoAzure:devfrom
audunn:ANF-5207AddMissingSnapshotRestoreFunctionInAzureCLI
May 15, 2020
Merged

[NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function#13481
haroldrandom merged 8 commits intoAzure:devfrom
audunn:ANF-5207AddMissingSnapshotRestoreFunctionInAzureCLI

Conversation

@audunn
Copy link
Member

@audunn audunn commented May 13, 2020

Description

This is a bug fix for an issue where a missing features/functions missing from CLI this blocked users from creating volumes from snapshots.

Testing Guide

Add a snapshot id as a parameter to create volume to create a volume from existing snapshot.
netappfiles volume create --resource-group %s --account-name accontName --pool-name poolName --volume-name volumeName -l location --service-level 'Premium' --usage-threshold 100 --file-path path --vnet vNet --subnet subnetId --snapshot-id snapshotId

History Notes

[NetAppFiles] az volume create: Adds snapshot-id as a parameter to create volume this will allow users to create a volume from existing snapshot.


This checklist is used to make sure that common guidelines for a pull request are followed.

@audunn audunn changed the title [NetAppFiles] Anf 5207 add missing snapshot restore function in azure cli [NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function in azure cli May 13, 2020
@yonzhan yonzhan requested review from jsntcy and mmyyrroonn May 14, 2020 00:25
@yonzhan yonzhan added this to the S170 milestone May 14, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented May 14, 2020

add to S170

@@ -0,0 +1,3 @@
{
"lockfileVersion": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of adding this file?

Copy link
Member Author

@audunn audunn May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not sure must have been added by a tool like a package manager, perhaps added when I updated azdev. I removed id.

Copy link
Contributor

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comment

Co-authored-by: Jianhui Harold <haroldrandom@gmail.com>
@audunn
Copy link
Member Author

audunn commented May 15, 2020

please review note this is urgently needed by MSFT for high-profile engagement

@haroldrandom haroldrandom changed the title [NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function in azure cli [NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function May 15, 2020
@haroldrandom haroldrandom merged commit ee84afb into Azure:dev May 15, 2020
derekbekoe added a commit to derekbekoe/azure-cli that referenced this pull request May 18, 2020
* 'dev' of https://github.com/Azure/azure-cli: (85 commits)
  {Monitor} az monitor autoscale profile show: bug fix (Azure#13515)
  [Monitor] az monitor diagnostic-settings create: support --export-to-specific-resource argument (Azure#13544)
  [aro]Add tests for generate_random_id function (Azure#13522)
  [ARO]Change CLIError to correct flag for --worker-vm-disk-size-gb (Azure#13439)
  [Packaging] Add Ubuntu Focal Package (Azure#13491)
  Update parse_zone_file.py (Azure#13377)
  {Release} Upgrade to Azure CLI 2.6.0 (Azure#13542)
  fix (Azure#13511)
  {Resource} Add example to tell how to pass array to --parameters (Azure#13510)
  [NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function (Azure#13481)
  {Network} az network nic create: Refine help message (Azure#13513)
  [Storage] az storage blob sync: Fix the incorrect error message when azcopy cannot find the installation location (Azure#9576)  (Azure#13104)
  Support --connect-string for az storage blob sync (Azure#13135)
  Modify the deprecate information for deployment operation (Azure#13390)
  [AppService] Onboard local context for app service (Azure#12984)
  {Monitor} az monitor metrics alert: refine severity explanation (Azure#13512)
  [IoT Hub] Support for 2020-03-01 API and Network Isolation commands (Azure#13467)
  [Compute] az vm list-skus: Update --zone behavior, return all type skus now (Azure#13470)
  Fix that cli doe not fail when user only specifies Windows password (Azure#13418)
  {ACR}: expose --expiration from token commands (Azure#13451)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants