Skip to content

{Monitor} az monitor diagnostic-settings create: support --export-to-specific-resource argument #13544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmyyrroonn merged 2 commits into from
May 18, 2020
Merged

{Monitor} az monitor diagnostic-settings create: support --export-to-specific-resource argument #13544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a099311
finish
May 18, 2020
4e98611
fix style
May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/azure-cli/azure/cli/command_modules/monitor/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,11 @@ def load_arguments(self, _):
c.resource_parameter('resource_uri', required=True, arg_group='Target Resource', skip_validator=True)
c.argument('logs', type=get_json_object)
c.argument('metrics', type=get_json_object)
c.argument('export_to_specific_resource', arg_type=get_three_state_flag(),
help='Indicate that the export to LA must be done to a resource specific table, '
'a.k.a. dedicated or fixed schema table, '
'as opposed to the default dynamic schema table called AzureDiagnostics. '
'This argument is effective only when the argument --workspace is also given.')

with self.argument_context('monitor diagnostic-settings categories list') as c:
c.resource_parameter('resource_uri', required=True)
Expand Down
11 changes: 8 additions & 3 deletions src/azure-cli/azure/cli/command_modules/monitor/operations/diagnostics_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,25 @@
# --------------------------------------------------------------------------------------------


# pylint: disable=unused-argument
# pylint: disable=unused-argument, line-too-long
def create_diagnostics_settings(client, name, resource_uri,
logs=None,
metrics=None,
event_hub=None,
event_hub_rule=None,
storage_account=None,
workspace=None):
workspace=None,
export_to_specific_resource=None):
from azure.mgmt.monitor.models import DiagnosticSettingsResource
from knack.util import CLIError
if export_to_specific_resource and workspace is None:
raise CLIError('usage error: --workspace and --export-to-specific-resource')
parameters = DiagnosticSettingsResource(storage_account_id=storage_account,
workspace_id=workspace,
event_hub_name=event_hub,
event_hub_authorization_rule_id=event_hub_rule,
metrics=metrics,
logs=logs)
logs=logs,
log_analytics_destination_type='Dedicated' if export_to_specific_resource else None)

return client.create_or_update(resource_uri=resource_uri, parameters=parameters, name=name)
Loading