{Identity} Support UsernamePasswordCredential.authenticate#13604
Merged
jiasli merged 1 commit intoAzure:identityfrom May 21, 2020
Merged
{Identity} Support UsernamePasswordCredential.authenticate#13604jiasli merged 1 commit intoAzure:identityfrom
jiasli merged 1 commit intoAzure:identityfrom
Conversation
jiasli
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom and
qianwens
as code owners
qianwens
approved these changes
May 21, 2020
jiasli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the removal of
UsernamePasswordCredential.authenticate, when username+password is used as the authentication method, Azure CLI can't persist user'sAuthenticationRecordand utilize refresh tokens stored in MSAL cache. In such case, Azure CLI will have to save user's password by itself, which is absolutely not a good idea from a security perspective. See Azure/azure-sdk-for-python#11449, Azure/azure-sdk-for-python#11546This PR solves the above issue by incorporating the changes from Azure/azure-sdk-for-python#11528
⚠ However, using this
AuthenticationRecordcorrectly remains unsolved: Azure/azure-sdk-for-python#11448. We useInteractiveBrowserCredentialas a temporary workaround:azure-cli/src/azure-cli-core/azure/cli/core/_identity.py
Lines 292 to 293 in 595646e
Testing Guide