[ACS] Remove private cluster and 2019-10-27-preview API#13618
Merged
[ACS] Remove private cluster and 2019-10-27-preview API#13618
Conversation
This reverts commit cd405fa.
…10-27-preview API version (Azure#12240)" This reverts commit 32e5102.
Collaborator
|
ACS |
Member
|
Parameter name should not contain "id" |
qwordy
reviewed
May 28, 2020
| short-summary: The Object ID of an Azure Active Directory Group that memberships will get synced into the OpenShift group "osa-customer-admins". If not specified, no cluster admin access will be granted. | ||
| - name: --workspace-id | ||
| type: string | ||
| short-summary: The resource id of an existing Log Analytics Workspace to use for storing monitoring data. |
Member
There was a problem hiding this comment.
Does it support name?
This question also applies to other parameters that only support id.
Author
There was a problem hiding this comment.
Hi @qwordy this is a revert to the code that was there before. We had a numerous discussions about this name in the past. Also we are sunsetting the ARO v3 service and do not want to introduce any more changes.
qwordy
approved these changes
May 28, 2020
Author
Member
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts OSA support for
2019-10-17-previewAPI version and private clusters. The reason is that in order to use these features the customer's subscription either has to be whitelisted, or feature gate to be removed. Since we have GA'ed ARO v4, we are encouraging customers to use private clusters in v4 rather than v3, hence reverting this change which was broke the client for some customers.Azure/OpenShift#183
Testing Guide
create an OpenShift cluster
az openshift create -g <group_name> -n <resource_name> --location eastus2try show or list command:
az openshift listaz openshift show -g <group_name> -n <resource_name>They should execute without error and display the cluster info.
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.