Conversation
|
add to S171 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Because Thus, Since there is no support for file-level |
| logger.info("command ran in %.3f seconds.", elapsed_time) | ||
| # Log the invoke finish time | ||
| invoke_finish_time = timeit.default_timer() | ||
| logger.info("Command ran in %.3f seconds (init: %.3f, invoke: %.3f)", |
There was a problem hiding this comment.
I am not sure if this running time info should be moved to logger.debug. I am open to this.
haroldrandom
left a comment
There was a problem hiding this comment.
Would it better to calculate the execution time under certain situations such as debug mode, --verbose mode, etc.
But this modifcation doesn't bring any (significant) regression, So, LGTM.
The execution time is calculated regardless of the execution mode (verbose, debug). Anyway, the overhead of calling |
Description
Fix the incorrect timing logic. Previous it only takes
invokeduration into account, while forgetting about theinitduration.This PR fixes the timing logic to include both
initandinvokeduration.Testing Guide
Before:
After: