Skip to content

{Core} refine local context message#14227

Merged
arrownj merged 2 commits intoAzure:devfrom
arrownj:refine_local_context_message
Jul 9, 2020
Merged

{Core} refine local context message#14227
arrownj merged 2 commits intoAzure:devfrom
arrownj:refine_local_context_message

Conversation

@arrownj
Copy link
Contributor

@arrownj arrownj commented Jul 6, 2020

Description
This PR is to fix #14015 .

PM want to refine some of local context message.

Testing Guide

az local-context on

Command group 'local-context' is experimental and not covered by customer support. Please use with discretion.
Local context is turned off, you can run az local-context on to turn it on.

az group create -g xxj -l westus2

Local context is turned on. Its information is saved in working directory D:\code\cli\azure-cli. You can run az local-context off to turn it off.
Your preference of: --name: xxj, --location: westus2 are now saved to local context. To learn more, type in az local-context --help

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@arrownj arrownj self-assigned this Jul 6, 2020
@yungezz yungezz added this to the S172 milestone Jul 7, 2020
@Azure Azure deleted a comment from yonzhan Jul 7, 2020
@arrownj arrownj marked this pull request as ready for review July 8, 2020 08:38
Comment on lines +150 to +151
logger.warning('Your preference of: %s now saved to local context. To learn more, type in az '
'local-context --help', ', '.join(args_str) + ' is' if len(args_str) == 1 else ' are')
Copy link
Member

@jiasli jiasli Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colon seems weird to me. How about

Suggested change
logger.warning('Your preference of: %s now saved to local context. To learn more, type in az '
'local-context --help', ', '.join(args_str) + ' is' if len(args_str) == 1 else ' are')
logger.warning('Your preference of '%s' are now saved to local context. To learn more, type in `az
'local-context --help`, ', '.join(args_str) + ' is' if len(args_str) == 1 else ' are')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use backticks (`) to denote commands. See #13060.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 9, 2020

Core

@arrownj arrownj merged commit 41758b5 into Azure:dev Jul 9, 2020
@arrownj arrownj deleted the refine_local_context_message branch July 29, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[local context] refine error message

4 participants