{Core} refine local context message#14227
Merged
Conversation
jiasli
approved these changes
Jul 9, 2020
Comment on lines
+150
to
+151
| logger.warning('Your preference of: %s now saved to local context. To learn more, type in az ' | ||
| 'local-context --help', ', '.join(args_str) + ' is' if len(args_str) == 1 else ' are') |
Member
There was a problem hiding this comment.
The colon seems weird to me. How about
Suggested change
| logger.warning('Your preference of: %s now saved to local context. To learn more, type in az ' | |
| 'local-context --help', ', '.join(args_str) + ' is' if len(args_str) == 1 else ' are') | |
| logger.warning('Your preference of '%s' are now saved to local context. To learn more, type in `az | |
| 'local-context --help`, ', '.join(args_str) + ' is' if len(args_str) == 1 else ' are') |
Member
There was a problem hiding this comment.
We usually use backticks (`) to denote commands. See #13060.
Collaborator
|
Core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix #14015 .
PM want to refine some of local context message.
Testing Guide
az local-context onaz group create -g xxj -l westus2History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.