Skip to content

[SQL] Add az sql mi op list, az sql mi op get to display operation steps and operation parameters#14515

Closed
toki95 wants to merge 33 commits intoAzure:devfrom
toki95:operationsUpdate
Closed

[SQL] Add az sql mi op list, az sql mi op get to display operation steps and operation parameters#14515
toki95 wants to merge 33 commits intoAzure:devfrom
toki95:operationsUpdate

Conversation

@toki95
Copy link
Contributor

@toki95 toki95 commented Jul 24, 2020

Description

Add az sql mi op list, az sql mi op get to display operation steps and operation parameters
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan added this to the S174 milestone Jul 24, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 24, 2020

add to S174

@Juliehzl
Copy link
Contributor

Hi @toki95 , could you take a look at failed tests?

@toki95
Copy link
Contributor Author

toki95 commented Jul 27, 2020

Hi @toki95 , could you take a look at failed tests?

These tests don't correlate to my change, I've informed the owning team of these failures.

@toki95
Copy link
Contributor Author

toki95 commented Jul 29, 2020

@Juliehzl friendly ping :)

@mmyyrroonn
Copy link
Contributor

@toki95 I thought the failed tests are test_sql_managed_db_short_retention, test_sql_managed_deleted_db_restore, test_sql_managed_db_mgmt and test_sql_managed_db_long_term_retention which are related with SQL.

@toki95
Copy link
Contributor Author

toki95 commented Aug 3, 2020

Yes, but not with this change. I have informed the team. We can merge this.

@toki95
Copy link
Contributor Author

toki95 commented Aug 4, 2020

@myronfanqiu ping :)

@mmyyrroonn
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mmyyrroonn
Copy link
Contributor

@toki95 Hi. Since you change the sdk's verison and the api-version is also changed. You have to re-run the failed tests lively. These four failed tests should be caused your change.

@mmyyrroonn
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@toki95 toki95 requested a review from jaredmoo as a code owner August 5, 2020 08:41
@toki95
Copy link
Contributor Author

toki95 commented Aug 5, 2020

@myronfanqiu tests fixed, please merge.

@mmyyrroonn
Copy link
Contributor

Approved. @Juliehzl I'm not code owner. Please help merge this pr.

@Juliehzl
Copy link
Contributor

Juliehzl commented Aug 5, 2020

Hi @toki95, it seems you just replace the api version. Could we run all test in live mode for sql service to prevent there is breaking change for sql related command with new sdk version?

@toki95
Copy link
Contributor Author

toki95 commented Aug 10, 2020

New PR #14728.
Old closed due to branch issues.

@toki95 toki95 closed this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants