Skip to content

[ARM] az deployment group/sub/mg/tenant what-if: Show "Ignore" resource changes last#14932

Merged
Juliehzl merged 1 commit intoAzure:devfrom
shenglol:what-if-sort-change-types
Sep 10, 2020
Merged

[ARM] az deployment group/sub/mg/tenant what-if: Show "Ignore" resource changes last#14932
Juliehzl merged 1 commit intoAzure:devfrom
shenglol:what-if-sort-change-types

Conversation

@shenglol
Copy link
Contributor

@shenglol shenglol commented Aug 26, 2020

Description

The PR contains a minor tweak for the az deployment group/sub/mg/tenant what-if commands to let them show "Ignore" resource changes last in outputs (addresses Azure/arm-template-whatif#115).

Before the change:
before

After the change:
after

Testing Guide

az deployment group/sub/mg/tenant what-if -m <mg_id> -f <path_to_deployment_file> -l <location>
az deployment group/sub/mg/tenant create -m <mg_id> -f <path_to_deployment_file> -l <location> -c

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 27, 2020

ARM

@yonzhan yonzhan requested review from jsntcy and mmyyrroonn August 27, 2020 01:37
@shenglol
Copy link
Contributor Author

Hi @jsntcy and @myronfanqiu, can you help review this PR?

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Sep 1, 2020

@shenglol Could you please add the demo of specific changes brought by this modification to the PR description? (It will be better with comparative information)
By the way, may I ask does it cause breaking change?

@shenglol
Copy link
Contributor Author

shenglol commented Sep 1, 2020

@shenglol Could you please add the demo of specific changes brought by this modification to the PR description? (It will be better with comparative information)
By the way, may I ask does it cause breaking change?

Sure, added a demo to the description section. It is not a breaking change, because it only updates how results are rendered. The underlying data is still the same.

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenglol
Copy link
Contributor Author

shenglol commented Sep 2, 2020

@Juliehzl can you help take a look at this?

@Juliehzl Juliehzl merged commit 4a415fe into Azure:dev Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants