Skip to content

{ARM} Fix the bug for live test#14962

Merged
zhoxing-ms merged 1 commit intoAzure:devfrom
zhoxing-ms:fix_live_test_error
Sep 4, 2020
Merged

{ARM} Fix the bug for live test#14962
zhoxing-ms merged 1 commit intoAzure:devfrom
zhoxing-ms:fix_live_test_error

Conversation

@zhoxing-ms
Copy link
Contributor

@zhoxing-ms zhoxing-ms commented Aug 28, 2020

Description

Fix the bug for live test:

1. Fixed resource names

  • Errors:
    • test_subscription_level_deployment The storage account named armbuilddemo18221 is already taken
    • test_subscription_level_deployment_old_command The storage account named armbuilddemo18221 is already taken.
    • test_group_deployment_with_large_params cli_test_deployment_with_large_paramsxxx is not valid.
  • Solutions:
    • Use the random method to change the resource name to a random value

2. The subscription ID belonging to service team is used

  • Errors:
    • test_management_group_deployment knack.util.CLIError: Azure Error: CrossTenantDeploymentNotPermitted
    • test_management_group_level_what_if knack.util.CLIError: Azure Error: CrossTenantDeploymentNotPermitted
    • test_resource_policy_management_group Reader level access is required on the management group or group ancestors.
  • Solutions:
    • Change the subscription ID to our own

3. The check status value is not correct

  • Errors:
    • test_feature_unregister 'properties.state' doesn't yield expected value 'Unregistered', instead the actual value is 'Unregistering'
  • Solutions:
    • Change to the correct check value

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@zhoxing-ms zhoxing-ms requested a review from Juliehzl as a code owner August 28, 2020 10:29
@yonzhan yonzhan requested review from jsntcy and mmyyrroonn August 28, 2020 15:46
@yonzhan yonzhan added this to the S175 - For Ignite milestone Aug 28, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 28, 2020

ARM

@fengzhou-msft fengzhou-msft requested a review from qwordy August 30, 2020 15:51
@zhoxing-ms zhoxing-ms force-pushed the fix_live_test_error branch 4 times, most recently from 3361661 to 1a95cb0 Compare August 31, 2020 09:23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that it is finished? Can we check Unregistered or Unregistering?

Copy link
Contributor Author

@zhoxing-ms zhoxing-ms Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is possible~ Actually, I sent an email to the service team to ask the expected status before, but I haven't received any reply yet.
If I receive a reply, I will sync the information in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe regular expression works

@zhoxing-ms zhoxing-ms merged commit 5c86afc into Azure:dev Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants