Merged
Conversation
yungezz
approved these changes
Sep 1, 2020
haroldrandom
approved these changes
Sep 4, 2020
qwordy
reviewed
Sep 4, 2020
|
|
||
| for mod_name in mod_list: | ||
| if mod_name in ['botservice', 'network']: | ||
| if mod_name in ['botservice', 'network', 'cloud']: |
Member
Author
There was a problem hiding this comment.
Add cloud to the modules that need to be run in serial.
jiasli
approved these changes
Sep 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running cloud tests in parallel, it may fail to revert to the original cloud settings. The tests relies on
setup()to get the original active cloud andtearDown()to set back to the original cloud. But when running in parallel, if the original cloud is A, it is possible that process 1 runs a test to set to cloud B, then process 2 begins and treats cloud B as the original cloud in enviroment. Process 1 finishes and set the cloud back to A, process 2 finishes and set the cloud back to B. Now the cloud of the environemnt changes from cloud A to cloud B. This will cause issues with other tests running afterwards.This PR modifies package tests to run cloud tests in serial and add
serial_testmark to run in serial in live test pipeline.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.