{Core} Print error details if fail to get msal token#15004
Conversation
arrownj
requested review from
Juliehzl,
fengzhou-msft,
haroldrandom,
jiasli,
jsntcy and
mmyyrroonn
as code owners
Collaborator
|
Core |
yungezz
reviewed
Sep 1, 2020
| response = client.obtain_token_by_refresh_token(refresh_token, scope=scopes, **kwargs) | ||
| if "error" in response: | ||
| raise CLIError(response["error"]) | ||
| raise CLIError("Get token failed. {error}: {error_description}".format(**response)) |
jiasli
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently if the
get_msal_tokenfunction fails, it will only print an error "invalid_grant", which is not enough to guide user to do further actions. This PR is to print the error details of it.Testing Guide
Need to test via vmssh extension.
current behavior:
expected behavior:
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.