[Compute] Upgrade disk API version to 2020-06-30 and some new features#15031
Merged
[Compute] Upgrade disk API version to 2020-06-30 and some new features#15031
Conversation
qwordy
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom,
jiasli,
jsntcy and
mmyyrroonn
as code owners
10 tasks
Collaborator
|
Compute |
qwordy
changed the title
fengzhou-msft
approved these changes
Sep 8, 2020
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
Member
Author
|
Create an issue to track failed tests. |
andyzhangx
reviewed
Sep 9, 2020
| ResourceType.MGMT_NETWORK: '2020-05-01', | ||
| ResourceType.MGMT_COMPUTE: SDKProfile('2020-06-01', { | ||
| 'resource_skus': '2019-04-01', | ||
| 'disks': '2020-05-01', |
Contributor
There was a problem hiding this comment.
is 2020-06-1 api-version available on all regions including sovereign cloud, e.g. Azure China?
@VybavaRamadoss
Contributor
There was a problem hiding this comment.
/hold
hold on a moment for confirm, thanks.
arrownj
reviewed
Sep 9, 2020
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Outdated
Show resolved
Hide resolved
arrownj
approved these changes
Sep 9, 2020
haroldrandom
approved these changes
Sep 9, 2020
Contributor
haroldrandom
left a comment
haroldrandom
left a comment
There was a problem hiding this comment.
Network is ok from my side
Member
Author
|
@v-Ajnava Can you review this PR? You are code owner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #14899
[Compute] Upgrade disk API version to 2020-06-30
[Compute]
disk create: add--logical-sector-size,--tierLogical sector size in bytes for Ultra disks. Supported values are 512 ad 4096. 4096 is the default.
[Compute]
disk update: Support--disk-iops-read-only,--disk-mbps-read-only,--max-shares[Compute] new command
disk-encryption-set list-associated-resourcesTesting Guide
History Notes
[Compute] Upgrade disk API version to 2020-06-30
[Compute]
disk create: add--logical-sector-size,--tier[Compute]
disk update: Support--disk-iops-read-only,--disk-mbps-read-only,--max-shares[Compute] new command
disk-encryption-set list-associated-resourcesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.