Conversation
Collaborator
|
sql |
petrajkogit
changed the title
Contributor
Author
|
@yonzhan I see that you have selected S176 as milestone. Can you please change it to S175, since we have strict GA deadline for the feature I am adding, and S175 is the only release that is appropriate for us? |
Collaborator
|
@petrajkogit does this PR target for Ignite? |
Contributor
Author
|
@yonzhan This is not specifically targeted for Ignite, but for GA milestone that matches with dates for Ignite (actually we need to be GA by the end of Septempber, and Ignite is a bit earlier). Also, I see that Juliehzl is OOF for two more days. Can you reassign this, please, to someone else? |
Collaborator
|
@zhoxing-ms please help with this PR. |
zhoxing-ms
reviewed
Sep 9, 2020
zhoxing-ms
reviewed
Sep 9, 2020
zhoxing-ms
reviewed
Sep 9, 2020
Juliehzl
reviewed
Sep 11, 2020
Juliehzl
reviewed
Sep 11, 2020
Juliehzl
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add backup storage redundancy optional parameter to MI create cmdlet
Updated azure-mgmt-sql package to version 0.21.0, and rerecorded tests
Testing Guide
az sql mi create --resource-group myrg --name azureclitestbsr --location westeurope --admin-user myuser --admin-password myPass --license-type LicenseIncluded --subnet "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/toki/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/ManagedInstance" --capacity 8 --storage 64 --family Gen5 --tier GeneralPurpose --backup-storage-redundancy Local
History Notes
[SQL] Add backup storage redundancy optional parameter to MI create cmdlet
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.