{Packaging} Remove unused Network SDK APIs#15082
Merged
fengzhou-msft merged 3 commits intoAzure:devfrom Sep 9, 2020
Merged
Conversation
Member
|
hi @myronfanqiu could you pls help to review the change? thanks |
haroldrandom
approved these changes
Sep 9, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Network SDK size is big (about 117 MB on Windows after installation) and contains a lot of old APIs CLI does not use. We can remove the unused APIs to reduce the CLI packge size.
A list of API versions CLI uses:
search
ResourceType.MGMT_NETWORKin _shared.py:2015-06-15
2017-10-01
2019-06-01
2020-05-01
get_target_network_api in vm:
2018-01-01
Referenced by models.py of Network SDK v11.0.0:
2018_07_01
2019_02_01
2019_07_01
2020_04_01
2020_05_01
This PR removed unused Network APIs (not in the above list) in MSI and RPM building scripts.
MSI package size reduced from 45 MB to 42 MB.
RPM package size reduced from 32 MB to 28 MB.
Testing Guide
Built and tested packages in build_test branch: https://dev.azure.com/azure-sdk/public/_build/results?buildId=527177&view=results
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.