[AKS] Remove legacy aci connector actions#15084
Merged
Conversation
Collaborator
|
aks |
gossion
force-pushed
the
guwe/rm-connector-actions
branch
from
9b41876 to
6eeaf63
Compare
gossion
changed the title
arrownj
reviewed
Sep 9, 2020
Contributor
arrownj
left a comment
arrownj
left a comment
There was a problem hiding this comment.
Is there any test case which relate to this before ?
Member
Author
@arrownj , No, I don't see any test for these actions. |
Member
Author
Member
|
is there any command in aks-preview extension, if yes, will they be deleted together? Is there existing user using the command? |
Contributor
|
@gossion thanks for driving this removal, LGTM but we'll need to do the same cleanup the cli-extension as well. cc @robbiezhang for review |
Contributor
|
cli extension doesn't override these 3 commands. |
robbiezhang
approved these changes
Sep 9, 2020
arrownj
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AKS has managed ACI (via
virtual-nodeaddon) available for a while, the legacy ACI connection actions (install-connector&remove-connector&upgrade-connector) should be retired.Testing Guide
History Notes
[AKS] BREAKING CHANGE: az aks install-connector/upgrade-connector/remove-connector is removed as they are not functional anymore.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.