[Core] Add 2020-09-01-hybrid API profile for AzureStack#15096
Merged
[Core] Add 2020-09-01-hybrid API profile for AzureStack#15096
Conversation
abbhar
requested review from
Juliehzl,
arrownj,
dbradish-microsoft,
fengzhou-msft,
haroldrandom,
jiasli,
jsntcy,
mmyyrroonn and
qwordy
as code owners
bganapa
changed the title
Collaborator
|
DNM |
qwordy
reviewed
Sep 9, 2020
jiasli
approved these changes
Sep 11, 2020
Juliehzl
reviewed
Sep 29, 2020
src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/recording_processors.py
Show resolved
Hide resolved
Juliehzl
reviewed
Sep 29, 2020
Juliehzl
reviewed
Sep 29, 2020
src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/_test_utils.py
Show resolved
Hide resolved
Juliehzl
reviewed
Sep 29, 2020
Juliehzl
reviewed
Sep 29, 2020
abbhar
force-pushed
the
abbhar/profile-2020
branch
2 times, most recently
from
bca0bb9 to
13a0e45
Compare
abbhar
force-pushed
the
abbhar/profile-2020
branch
from
e4d76aa to
187dc3c
Compare
abbhar
changed the title
Contributor
Juliehzl
changed the title
bganapa
approved these changes
Dec 2, 2020
Member
|
This is good to be merged!. Thanks @Juliehzl for all the inputs in taking this PR to green! |
haroldrandom
reviewed
Dec 3, 2020
haroldrandom
reviewed
Dec 3, 2020
fengzhou-msft
approved these changes
Dec 3, 2020
haroldrandom
approved these changes
Dec 3, 2020
digimaun
reviewed
Dec 3, 2020
src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/test_iot_dps_commands.py
Show resolved
Hide resolved
digimaun
reviewed
Dec 3, 2020
src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/test_iot_commands.py
Show resolved
Hide resolved
digimaun
reviewed
Dec 3, 2020
...azure-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/test_iot_central_commands.py
Show resolved
Hide resolved
digimaun
reviewed
Dec 3, 2020
src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/test_iot_commands.py
Show resolved
Hide resolved
digimaun
reviewed
Dec 3, 2020
...e-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/test_iot_certificate_commands.py
Show resolved
Hide resolved
qwordy
approved these changes
Dec 4, 2020
kairu-ms
approved these changes
Dec 4, 2020
Contributor
|
@abbhar May I ask why there are no resource module related tests? |
jiasli
approved these changes
Dec 4, 2020
bim-msft
approved these changes
Dec 4, 2020
Juliehzl
reviewed
Dec 4, 2020
|
|
||
| # @ResourceGroupPreparer() | ||
| # @StorageAccountPreparer() | ||
| # def test_renew_account_key(self, resource_group, storage_account): |
Contributor
There was a problem hiding this comment.
it could work with ADDS configured.
If it is supported in Azure Stack, we need to work on reverting the test.
Contributor
zhoxing-ms
approved these changes
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding New Api Profile 2020-09-01-hybrid for Azure Stack.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.