{Profile} Fix: test_get_raw_token fails on non-UTC machine#15131
Merged
{Profile} Fix: test_get_raw_token fails on non-UTC machine#15131
Conversation
…trings datetime.fromtimestamp will use the machine's locale timezone by default, causing expiration timestamps to vary depending on the local setting. Use UTC to ensure they are stable. (cherry picked from commit ea0b891)
Collaborator
|
Profile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by #14718. Fix:
test_get_raw_tokenfails on non-UTC machine.The test
test_get_raw_tokenwas introduced in #14128.When using
az account get-access-tokenfor managed identity,expiresOnwill be converted from POSIX to datetime in local timezone. For example,1593497681is converted to2020-06-30 06:14:41.000000on a UTC machine2020-06-30 14:14:41.000000on a UTC+8 machineThe test
test_get_raw_token failsis written for a UTC machine on DevOps and this test will fail on a non-UTC machine (such as UTC+8).This PR patches
fromtimestampwithutcfromtimestampto forceexpiresOnto be converted to UTC to make the test pass on any machine.